feat: Box Select 컴포넌트 추가 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeMatthewsong
requested review from
HMRyu,
yunchaeney and
hakyoung12
as code owners
HMRyu
reviewed
Sep 6, 2024
| } | ||
|
|
||
| const BoxSelect = ({ title = '', subTitle = '' }: BoxSelectProps) => { | ||
| const [selectStatus, setSelectStatus] = useState<boolean>(false); |
There was a problem hiding this comment.
P3) state 이름을 isSelected 라고 변경해도 좋을 것 같습니다!
There was a problem hiding this comment.
아하 확실히 그게 더 좋겠네요!
반영하도록 하겠습니다!
Comment on lines
24
to
26
| <label | ||
| className={`flex h-76 w-full items-start gap-8 rounded-lg ${selectStatus ? 'bg-var-gray-900 text-var-white' : 'bg-var-gray-50 text-var-black'} md:h-70 lg:h-70 px-8 py-[6px] transition-colors duration-200 ease-in-out md:px-16 md:py-12 lg:px-16 lg:py-12`} | ||
| > |
| onChange={handleCheckboxChange} | ||
| /> | ||
| <div className='flex flex-col'> | ||
| <div className='text-[14px] font-bold md:text-[16px] lg:text-[16px]'> |
There was a problem hiding this comment.
P2) md 이상이면 text 가 16px 인 것 같아서 굳이 lg:text-[16px] 은 안 적어도 될 것 같긴 합니다!
There was a problem hiding this comment.
text-16,text-14로 사용 할 수 있게 tailwind config 수정했습니다!
There was a problem hiding this comment.
두 분 의견 반영하겠습니다!
Comment on lines
+21
to
+24
| screens: { | ||
| md: { min: '768px' }, | ||
| lg: { min: '1024px' }, | ||
| }, |
HMRyu
approved these changes
Sep 6, 2024
hakyoung12
reviewed
Sep 6, 2024
Comment on lines
+21
to
+24
| screens: { | ||
| md: { min: '768px' }, | ||
| lg: { min: '1024px' }, | ||
| }, |
| <input | ||
| id='checkbox' | ||
| type='checkbox' | ||
| className="h-24 w-24 appearance-none rounded-md bg-[url('/icons/checkbox-default.svg')] bg-center bg-no-repeat checked:bg-[url('/icons/checkbox-active.svg')] checked:bg-center checked:bg-no-repeat" |
There was a problem hiding this comment.
P4) appearance 속성은 처음 보네요! 혹시 어떤 기능하는지 알려주실 수 있을까요?
There was a problem hiding this comment.
appearance-none은 체크박스 인풋의 기본 스타일을 무효화시키는 속성입니다.
BeMatthewsong
commented
Sep 6, 2024
| } | ||
|
|
||
| const BoxSelect = ({ title = '', subTitle = '' }: BoxSelectProps) => { | ||
| const [selectStatus, setSelectStatus] = useState<boolean>(false); |
There was a problem hiding this comment.
나중에 부모 컴포넌트에서 set함수를 받아서 관리할 것 같아서 이 부분은 추후에 변경이 필요해보입니다.
Comment on lines
24
to
39
| <label | ||
| className={`flex h-76 w-full items-start gap-8 rounded-lg ${selectStatus ? 'bg-var-gray-900 text-var-white' : 'bg-var-gray-50 text-var-black'} md:h-70 lg:h-70 px-8 py-[6px] transition-colors duration-200 ease-in-out md:px-16 md:py-12 lg:px-16 lg:py-12`} | ||
| > | ||
| <input | ||
| id='checkbox' | ||
| type='checkbox' | ||
| className="h-24 w-24 appearance-none rounded-md bg-[url('/icons/checkbox-default.svg')] bg-center bg-no-repeat checked:bg-[url('/icons/checkbox-active.svg')] checked:bg-center checked:bg-no-repeat" | ||
| onChange={handleCheckboxChange} | ||
| /> | ||
| <div className='flex flex-col'> | ||
| <div className='text-[14px] font-bold md:text-[16px] lg:text-[16px]'> | ||
| {title} | ||
| </div> | ||
| <div className='text-[12px] font-medium'>{subTitle}</div> | ||
| </div> | ||
| </label> |
There was a problem hiding this comment.
- label 를 상위 태그로 두면서 전체를 클릭하여도 input이 선택되도록 하였습니다.
- selectStatus에 따라 체크박스에 해당하는 이미지가 변하도록 하였습니다.
- transition을 넣으면서 부드러운 전환을 할 수 있게 했습니다.
| onChange={handleCheckboxChange} | ||
| /> | ||
| <div className='flex flex-col'> | ||
| <div className='text-[14px] font-bold md:text-[16px] lg:text-[16px]'> |
There was a problem hiding this comment.
두 분 의견 반영하겠습니다!
| } | ||
|
|
||
| const BoxSelect = ({ title = '', subTitle = '' }: BoxSelectProps) => { | ||
| const [selectStatus, setSelectStatus] = useState<boolean>(false); |
There was a problem hiding this comment.
아하 확실히 그게 더 좋겠네요!
반영하도록 하겠습니다!
| <input | ||
| id='checkbox' | ||
| type='checkbox' | ||
| className="h-24 w-24 appearance-none rounded-md bg-[url('/icons/checkbox-default.svg')] bg-center bg-no-repeat checked:bg-[url('/icons/checkbox-active.svg')] checked:bg-center checked:bg-no-repeat" |
There was a problem hiding this comment.
appearance-none은 체크박스 인풋의 기본 스타일을 무효화시키는 속성입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
📷 스크린샷
2024-09-06.2.07.50.mov
✍️ 사용법
🎸 기타
전체를 클릭하면 선택되게 수정하고 있습니다.
close #11