[Metrics] Use property session id generated each app session #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyuu-jin
reviewed
Dec 3, 2024
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "hyperplay", | |||
| "version": "0.22.1", | |||
| "version": "0.22.2-analytics", | |||
There was a problem hiding this comment.
Was this on purpose, are we putting semver tags in the versions now?
There was a problem hiding this comment.
There is a filter in the dev mixpanel for this app version so that we can see if the data only from this branch fixes the issue. I will revert to 0.22.2 before merging
flavioislima
approved these changes
Dec 3, 2024
BrettCleary
added
PR: Ready-For-Test
eliobricenov
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
switch to property based sessions.
related to https://github.com/HyperPlay-Gaming/product-management/issues/714