Fix/game closed event on main win close #1172
Conversation
| @@ -1161,228 +1182,231 @@ ipcMain.handle('isClientUpdating', async () => { | |||
|
|
|||
| ipcMain.on('restartClient', () => autoUpdater.quitAndInstall()) | |||
|
|
|||
| // get pid/tid on launch and inject | |||
| ipcMain.handle( | |||
There was a problem hiding this comment.
i basically moved all of this logic out into handleGameLaunch so that we could store the promise in allLaunchHandlerPromises to await on app quit
| @@ -161,6 +161,8 @@ export const trackEvent = async ({ | |||
| } | |||
| } | |||
|
|
|||
| export const flushEvents = async () => rudderstack.flush() | |||
There was a problem hiding this comment.
we have to flush the events in the launch handler so that Game Closed is sent on app close. Otherwise it is added to the cache and will wait a little while to see if there are other events that can be batch sent along with it
| @@ -256,9 +257,12 @@ async function handleExit() { | |||
| logInfo([`Unable to kill ${procName}, ignoring.`, error]) | |||
| } | |||
| }) | |||
| } | |||
| // Kill all child processes, closing browser and native games that are running | |||
| callAllAbortControllers() | |||
There was a problem hiding this comment.
this has to be called before the cleanUp function so that that launch handlers can finish executing
| @@ -29,7 +29,7 @@ function callAbortController(id: string) { | |||
| } | |||
|
|
|||
| function callAllAbortControllers() { | |||
| for (const key in abortControllers.keys()) { | |||
There was a problem hiding this comment.
This was causing native games launched through HP to not be closed when HP was closed
BrettCleary
added
blocked
PR: Ready-For-Review
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "hyperplay", | |||
| "version": "0.22.1", | |||
| "version": "0.22.2-analytics", | |||
There was a problem hiding this comment.
just for testing so I can filter for this version on the charts
|
Pretty sensitive code. Will need your review on this one @flavioislima |
There was a problem hiding this comment.
Code looks good! left a small comment.
Did some basic testing with Epic and GOG games to check if the sync-saves would work on app close and they are working as they should.
Ideally would be good to test the launch command pretty well just to guarantee nothing is broken on any platform for any runner.
| const allGameLaunchHandlersSettled = Promise.allSettled( | ||
| allLaunchHandlerPromises | ||
| ) | ||
| const oneSecondTimeout = new Promise((res) => { |
There was a problem hiding this comment.
maybe you could use the wait helper method we have here:
Would need to make it accept a string, or make it always return TIME_OUT which is fine as well, if you need the message ofc.
Summary
Give game launch handlers 1 second on main window close to clean up (i.e. sync playsession and send game closed event).
closes https://github.com/HyperPlay-Gaming/product-management/issues/714
also fixes an issue where call all abort controllers was not working on main window close
Testing
https://app.qase.io/case/HC-528