Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support providing multi config files #336
Support providing multi config files #336
Changes from 52 commits
3a4f797
183c768
d3a6d5d
1f7109c
184b1fb
aa4c87b
7107b92
873ab59
b292b3e
8483f1c
5319316
fd6b139
f20d583
aba6137
edf87a4
e115bd7
4855349
73b8507
2d22ee7
d4769f7
abeb2b1
9bfe250
d45c65f
23e5f04
70ef139
e1feefb
5a9f92d
5b87d7a
59f7815
bd5a278
b0a5769
dfa380c
bbf0377
62bc7f0
5c4bff8
214f958
f8e6052
7014938
c9f917e
0f879fd
bf58e94
d7beb69
558ce4b
814f8a4
3e6edb3
6424382
96cec5b
51a4860
0dd4c59
63f2759
daebcdc
cb91676
00591eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some examples would be informative to show the limitations. This could lead to very unexpected behaviour and since we have some external users, i think it would be useful to be explicit here about what this cannot do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will amend this - how about addressing, say, new seir scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest seperating the example with the configs by part in it's own folder, as it looks confusing at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still feel like these examples of the config by part should be in a separate folder than this tutorial (like config_by_ooart)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable, but I think that belongs in a more examples-organization-focused issue & PR.