Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing aggregation and some aesthetics in automatic postprocessing #273

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Fixing aggregation and some aesthetics in automatic postprocessing #273

merged 6 commits into from
Aug 5, 2024

Conversation

saraloo
Copy link
Contributor

@saraloo saraloo commented Jul 30, 2024 •
edited
Loading

WIP: Addressing some issues that arose during the disparities round related to the postprocessing and aggregation functions used in the classical flepi R inference.

Fixes:

  • change automatic postprocessing to show the fitting data and the simulated output in the same aggregation format used within the likelihood algorithm (ie using the getStats() function)
  • fix the date filtering in aggregation
  • test to confirm these fix the problems

This addresses #272

@saraloo saraloo changed the title DRAFT: Fixing aggregation and some aesthetics in automatic postprocessing Fixing aggregation and some aesthetics in automatic postprocessing Jul 30, 2024
@saraloo saraloo linked an issue Jul 31, 2024 that may be closed by this pull request
Aggregation error in R inference algorithm #272
Closed
shauntruelove
shauntruelove reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@shauntruelove shauntruelove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

shauntruelove
shauntruelove approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@shauntruelove shauntruelove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@saraloo saraloo requested a review from TimothyWillard August 5, 2024 12:56
@saraloo saraloo merged commit 058027b into main Aug 5, 2024
1 check passed
@saraloo saraloo deleted the fix-snapshot branch August 5, 2024 13:09
jcblemai pushed a commit that referenced this pull request Oct 3, 2024
@saraloo
Merge pull request #273 from HopkinsIDD/fix-snapshot
1666804 
Fixing aggregation and some aesthetics in automatic postprocessing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyWillard TimothyWillard TimothyWillard approved these changes

@shauntruelove shauntruelove shauntruelove approved these changes

@jcblemai jcblemai Awaiting requested review from jcblemai

@alsnhll alsnhll Awaiting requested review from alsnhll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aggregation error in R inference algorithm
3 participants
@saraloo @shauntruelove @TimothyWillard