-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boto3
dependency, add venv
/.venv
to .gitignore
#239
Conversation
…r isolated installs of gempyor.
Thanks, Tim, very good catch. Few thoughts: This originates from #218 which makes me wonder if we should add botocores as well or if it is included in boto. I'm also hesitant to force the user to install boto3 (which is not that easy in some conda environments) just for some batch functions that are not often used. Most of our users won't have an AWS CLI set up. Perhaps we should import boto just in the aws batch functions that need it (like it's done in batch/inference_job: you can run it locally without a CLI, only with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have much/any input, but thank you for looping me in! Good for my edification to see stuff like this!
…s into gempyor.utils.download_file_from_s3, GH-238
7a83279
I went ahead and made it an optional install target, my main concern is being able to successfully install and run the package following the quick start documentation and these dependencies are used in only one function. So if making this a required dependency for the package causes more headaches let's just go with the path of least resistance. |
Add dotenv file to gitignore since flepiMoP depends on having FLEPI_PATH and PROJECT_PATH env vars set.
Had to resolve merge conflicts related to the import of boto3 and botocore.
Thanks, that looks good to me. It's a bit unfortunate that the python setup tools do not support "negative" targets (e.g. a pip install gempyor with everything, and a pip install gemypor[light] with a stripped down version). But it has been requested for a long time. PR all good to merge, ty Tim |
Thanks for reviewing y'all! Merging this one in, I'm quite excited to clean up my |
Add `boto3` dependency, add `venv`/`.venv`/`.env` to `.gitignore`
Should address #238.