plotutils: fix erroneous use of the -flat_namespace flag
#94218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of our usual patches apply to their `configure` script, but, conveniently, we don't need one if we set `MACOSX_DEPLOYMENT_TARGET` appropriately. Let's also pass `--without-x` on macOS to avoid opportunistic linkage with X11 libraries. This is needed for bottling on Monterey. See Homebrew#94212.
carlocab
added
CI-no-bottles
iMichka
approved these changes
Feb 1, 2022
|
Here is the build: https://github.com/Homebrew/homebrew-core/actions/runs/1776838130 |
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?None of our usual patches apply to their
configurescript, but,conveniently, we don't need one if we set
MACOSX_DEPLOYMENT_TARGETappropriately.
Let's also pass
--without-xon macOS to avoid opportunistic linkagewith X11 libraries.
This is needed for bottling on Monterey. See #94212.