Undeprecate formulae with dependents #106848

carlocab · 2022-07-29T07:38:38Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Needed for Homebrew/brew#12770. I've left the existing deprecation lines in a comment to make it easier to find them without digging up Git logs, so they're easier to action later on.

These formulae being deprecated also violate our policy about formulae with dependents not being deprecated (unless the dependents themselves are deprecated). We can uncomment the deprecation lines when we're able to sort out the dependents.

This should help make sure we're not disabling formulae with dependents in #103904.

See also:

carlocab · 2022-07-29T07:43:42Z

It'd be nice to be able to work out which of these have dependents that can be deprecated as well, but there are a lot of them (~55), and I don't have the time to look into that many formulae for deprecation at the moment.

SMillerDev · 2022-07-29T07:43:43Z

I'm going to deprecate phplint so you can drop the [email protected] commit.

carlocab · 2022-07-29T07:45:01Z

I'm going to deprecate phplint so you can drop the [email protected] commit.

Dropped.

cho-m · 2022-07-29T08:13:01Z

Formula/bazaar.rb

-  deprecate! date: "2021-08-19", because: "is not supported. Check out `breezy` instead"
+  # Commented out while this formula still has dependents.
+  # deprecate! date: "2021-08-19", because: "is not supported. Check out `breezy` instead"


Not sure if this has any non-deprecated dependents.

brew seems to think schroedinger depends on bazaar:

schroedinger: * Dependency 'bazaar' is deprecated but has un-deprecated dependents. Either un-deprecate 'bazaar' or deprecate all of its dependents.

I guess from head build (url "lp:schroedinger", using: :bzr). Can we switch brew code to use breezy?

breezy is supposed to be a drop-in replacement, right? If so we probably should. Let me look at it. But I'd rather do it as a follow-up.

Homebrew/brew#13617

We probably need it to land in a tagged release before properly deprecating bazaar, though.

Formula/[email protected]

Needed for Homebrew/brew#12770.

Let's change this to match the deprecation date of `[email protected]`.

carlocab · 2022-07-29T09:07:34Z

@SMillerDev, @cho-m, let me know if you have more thoughts here. I'd like to merge this so I can get back to Homebrew/brew#12770.

This formula is still needed for formulae that do `using: :bzr`. Since the deprecation message won't be shown in the meantime, let's replace it with a caveat.

MikeMcQuaid · 2022-07-29T12:00:18Z

These formulae being deprecated also violate our policy about formulae with dependents not being deprecated (unless the dependents themselves are deprecated). We can uncomment the deprecation lines when we're able to sort out the dependents.

Should ideally turn this policy into a brew audit or brew test-bot check at some point.

carlocab · 2022-07-29T12:04:49Z

Should ideally turn this policy into a brew audit or brew test-bot check at some point.

That's the idea of Homebrew/brew#12770! I need this PR to be able to finish off Homebrew/brew#12770.

Or were you looking for something more than that?

BrewTestBot · 2022-07-29T12:05:48Z

🤖 A scheduled task has triggered a merge.

BrewTestBot · 2022-07-29T12:05:50Z

@carlocab has triggered a merge.

MikeMcQuaid · 2022-07-29T12:12:24Z

That's the idea of Homebrew/brew#12770! I need this PR to be able to finish off Homebrew/brew#12770.

Or were you looking for something more than that?

No, that's perfect, I forgot it existed 😂

Needed for Homebrew/brew#12770. Missed from Homebrew#106848.

carlocab · 2022-07-29T12:26:55Z

Missed one 😞 #106860

No, that's perfect, I forgot it existed 😂

No worries; I did too...

Needed for Homebrew/brew#12770. Missed from #106848. Closes #106860. Signed-off-by: BrewTestBot <[email protected]>

Bazaar is no longer maintained, and Breezy seems to be a drop-in replacement. I've tested the commands used in the download strategy and they seem to work. We need this in order to properly deprecate the `bazaar` formula. See Homebrew/homebrew-core#106848.

carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 29, 2022

carlocab mentioned this pull request Jul 29, 2022

formula_auditor: audit for deprecated dependencies Homebrew/brew#12770

Merged

7 tasks

carlocab force-pushed the undeprecate branch from c689de9 to 2649645 Compare July 29, 2022 07:44

cho-m reviewed Jul 29, 2022

View reviewed changes

Formula/[email protected] Outdated Show resolved Hide resolved

carlocab added 20 commits July 29, 2022 16:43

cmu-sphinxbase: undeprecate

d326a8a

Needed for Homebrew/brew#12770.

dep: undeprecate

abbb7d8

Needed for Homebrew/brew#12770.

docker-machine: undeprecate

fe518d0

Needed for Homebrew/brew#12770.

glide: undeprecate

6524771

Needed for Homebrew/brew#12770.

govendor: undeprecate

cba3fc1

Needed for Homebrew/brew#12770.

guile@2: undeprecate

faad6c4

Needed for Homebrew/brew#12770.

ilmbase: undeprecate

c4d4c39

Needed for Homebrew/brew#12770.

[email protected]: undeprecate

cdb2280

Needed for Homebrew/brew#12770.

jam: undeprecate

a64de41

Needed for Homebrew/brew#12770.

[email protected]: undeprecate

d5d69d8

Needed for Homebrew/brew#12770.

mpfi: undeprecate

34d40b6

Needed for Homebrew/brew#12770.

openexr@2: undeprecate

17bd413

Needed for Homebrew/brew#12770.

sdl: undeprecate

572acbf

Needed for Homebrew/brew#12770.

sdl_image: undeprecate

14bd42a

Needed for Homebrew/brew#12770.

sdl_mixer: undeprecate

6ff2f31

Needed for Homebrew/brew#12770.

sdl_net: undeprecate

56eb640

Needed for Homebrew/brew#12770.

sdl_sound: undeprecate

953ccca

Needed for Homebrew/brew#12770.

sdl_ttf: undeprecate

0878d98

Needed for Homebrew/brew#12770.

tbb@2020: undeprecate

2b03181

Needed for Homebrew/brew#12770.

[email protected]: undeprecate

0fc448f

Needed for Homebrew/brew#12770.

carlocab force-pushed the undeprecate branch from 2649645 to 0fc448f Compare July 29, 2022 08:43

[email protected]: adjust deprecation date

9fca7fd

Let's change this to match the deprecation date of `[email protected]`.

carlocab mentioned this pull request Jul 29, 2022

download_strategy: replace bazaar with breezy Homebrew/brew#13617

Merged

7 tasks

bazaar: undeprecate

2156180

This formula is still needed for formulae that do `using: :bzr`. Since the deprecation message won't be shown in the meantime, let's replace it with a caveat.

carlocab force-pushed the undeprecate branch from 3f7dfde to 2156180 Compare July 29, 2022 09:09

MikeMcQuaid approved these changes Jul 29, 2022

View reviewed changes

BrewTestBot closed this in 06eb0d7 Jul 29, 2022

carlocab deleted the undeprecate branch July 29, 2022 12:07

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 29, 2022

ykclient: undeprecate

b705623

Needed for Homebrew/brew#12770. Missed from Homebrew#106848.

carlocab mentioned this pull request Jul 29, 2022

ykclient: undeprecate #106860

Closed

6 tasks

BrewTestBot pushed a commit that referenced this pull request Jul 30, 2022

ykclient: undeprecate

4f7eb27

Needed for Homebrew/brew#12770. Missed from #106848. Closes #106860. Signed-off-by: BrewTestBot <[email protected]>

cho-m mentioned this pull request Jul 30, 2022

[email protected]: undeprecate #105069

Closed

6 tasks

github-actions bot added the outdated PR was locked due to age label Aug 29, 2022

github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Undeprecate formulae with dependents #106848

Undeprecate formulae with dependents #106848

carlocab commented Jul 29, 2022

carlocab commented Jul 29, 2022

SMillerDev commented Jul 29, 2022

carlocab commented Jul 29, 2022

cho-m Jul 29, 2022

carlocab Jul 29, 2022

cho-m Jul 29, 2022 •

edited

Loading

carlocab Jul 29, 2022

carlocab Jul 29, 2022

carlocab commented Jul 29, 2022

MikeMcQuaid commented Jul 29, 2022

carlocab commented Jul 29, 2022 •

edited

Loading

BrewTestBot commented Jul 29, 2022

BrewTestBot commented Jul 29, 2022

MikeMcQuaid commented Jul 29, 2022

carlocab commented Jul 29, 2022

Undeprecate formulae with dependents #106848

Undeprecate formulae with dependents #106848

Conversation

carlocab commented Jul 29, 2022

carlocab commented Jul 29, 2022

SMillerDev commented Jul 29, 2022

carlocab commented Jul 29, 2022

cho-m Jul 29, 2022

Choose a reason for hiding this comment

carlocab Jul 29, 2022

Choose a reason for hiding this comment

cho-m Jul 29, 2022 • edited Loading

Choose a reason for hiding this comment

carlocab Jul 29, 2022

Choose a reason for hiding this comment

carlocab Jul 29, 2022

Choose a reason for hiding this comment

carlocab commented Jul 29, 2022

MikeMcQuaid commented Jul 29, 2022

carlocab commented Jul 29, 2022 • edited Loading

BrewTestBot commented Jul 29, 2022

BrewTestBot commented Jul 29, 2022

MikeMcQuaid commented Jul 29, 2022

carlocab commented Jul 29, 2022

cho-m Jul 29, 2022 •

edited

Loading

carlocab commented Jul 29, 2022 •

edited

Loading