-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download_strategy: replace bazaar
with breezy
#13617
Conversation
Bazaar is no longer maintained, and Breezy seems to be a drop-in replacement. I've tested the commands used in the download strategy and they seem to work. We need this in order to properly deprecate the `bazaar` formula. See Homebrew/homebrew-core#106848.
Review period will end on 2022-08-01 at 09:05:08 UTC. |
@bayandin, since I think you looked at this before: this should work, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this should work
And you probably want to swap brew/Library/Homebrew/dependency_collector.rb Lines 163 to 164 in 508b48d
|
Right, thanks. Nice catch. |
Review period ended. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Bazaar is no longer maintained, and Breezy seems to be a drop-in
replacement.
I've tested the commands used in the download strategy and they seem to
work.
We need this in order to properly deprecate the
bazaar
formula.See Homebrew/homebrew-core#106848.