Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_strategy: replace bazaar with breezy #13617

Merged
merged 2 commits into from
Aug 1, 2022
Merged

download_strategy: replace bazaar with breezy #13617

merged 2 commits into from
Aug 1, 2022

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Bazaar is no longer maintained, and Breezy seems to be a drop-in
replacement.

I've tested the commands used in the download strategy and they seem to
work.

We need this in order to properly deprecate the bazaar formula.

See Homebrew/homebrew-core#106848.

Bazaar is no longer maintained, and Breezy seems to be a drop-in
replacement.

I've tested the commands used in the download strategy and they seem to
work.

We need this in order to properly deprecate the `bazaar` formula.

See Homebrew/homebrew-core#106848.
@BrewTestBot
Copy link
Member

Review period will end on 2022-08-01 at 09:05:08 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 29, 2022
@carlocab
Copy link
Member Author

@bayandin, since I think you looked at this before: this should work, right?

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this should work

@bayandin
Copy link
Member

And you probably want to swap bazaar with breezy here

elsif strategy <= BazaarDownloadStrategy
Dependency.new("bazaar", tags)

@carlocab
Copy link
Member Author

Right, thanks. Nice catch.

@carlocab carlocab enabled auto-merge July 29, 2022 17:46
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 1, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@carlocab carlocab merged commit ce8ef89 into Homebrew:master Aug 1, 2022
@carlocab carlocab deleted the bzr-breezy branch August 1, 2022 12:09
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants