add --autodetect option for bq load #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariuszAniszewski
force-pushed
the
autodetect-bq-schema
branch
from
3baa275 to
1b4a2a9
Compare
6 tasks
|
retest this please |
DariuszAniszewski
force-pushed
the
autodetect-bq-schema
branch
from
1b4a2a9 to
b5c315e
Compare
|
@asaksena can you please take a look on this or point some other reviewer? thanks btw - Is there some problem with test server? Locally running tests are passing without any problems and tests are failing on part far away from the changes. |
|
@asaksena can you also take a look on this? Thanks |
|
Darius, I will be testing and closing this PR out this week. Sorry for the delay. |
|
Hey @asaksena, any updates on this one? I just merged latest |
asaksena
approved these changes
Feb 21, 2018
|
Merged. |
10 tasks
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
--autodetectoption (suggested in #1552) to create schema based on uploaded data if table doesn't exists yet.It's also seem to be connected to #229. This PR doesn't follow idea from that issue, but final effect is the same - if table doesn't exists, it's being created. Advantage is that it doesn't require additional information and creates schema based on the data.