Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-3060] split one job into several jobs, one for each IO. #4378

Merged
merged 1 commit into from
Jan 11, 2018
Merged

[BEAM-3060] split one job into several jobs, one for each IO. #4378

merged 1 commit into from
Jan 11, 2018

Conversation

DariuszAniszewski
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@DariuszAniszewski
Copy link
Contributor Author

Run seed job

@DariuszAniszewski
Copy link
Contributor Author

Run Java TextIO Performance Test

@DariuszAniszewski
Copy link
Contributor Author

@chamikaramj For this PR to properly run, following tables must be created in BigQuery:

beam_performance.textioit_pkb_results
beam_performance.compressed_textioit_pkb_results
beam_performance.avroioit_pkb_results
beam_performance.tfrecordioit_pkb_results

or this PR on PerfKit that allows automatic creation must be merged.

@DariuszAniszewski
Copy link
Contributor Author

Run seed job

@DariuszAniszewski
Copy link
Contributor Author

Run Java TextIO Performance Test

@DariuszAniszewski
Copy link
Contributor Author

Run Java AvroIO Performance Test

@DariuszAniszewski
Copy link
Contributor Author

Run Java TextIO Performance Test

@DariuszAniszewski
Copy link
Contributor Author

Run Java CompressedTextIO Performance Test

@DariuszAniszewski
Copy link
Contributor Author

Run Java TFRecordIO Performance Test

@DariuszAniszewski
Copy link
Contributor Author

@chamikaramj Alan created tables and as you can see above tests are now passing. Each IO has own Jenkins job and pushes data to dedicated BQ table, there will be dedicated dashboard as well.
This PR is ready to review, PTAL
Thanks

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@chamikaramj chamikaramj merged commit 7f04ab3 into apache:master Jan 11, 2018
@DariuszAniszewski DariuszAniszewski deleted the filebasedioit-jenkins-refactor branch January 11, 2018 20:17
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
@chemelnucfin
Field path class (apache#4392)
93bb088 
* apache#4378 - Field Path

* review changes

* 2nd review changes

* 3rd review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszAniszewski @chamikaramj