Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript issues #281

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nickspaargaren
Copy link

@nickspaargaren nickspaargaren commented Sep 4, 2024

What

  • Fix TypeScript issues
  • Updates @sentry/react to v8
  • Updates connected-react-router to v6

How to test

  1. Run git checkout develop.
  2. Follow the build instructions to run the project.
  3. Run npx yarn tsc --noEmit
  4. Verify that there are currently two TypeScript errors (Sentry and ConnectedRouter).
  5. Checkout this branch / this PR.
  6. Run yarn install and optionally follow the build instructions again to run the project.
  7. Run npx yarn tsc --noEmit again.
  8. Verify that the TypeScript errors are gone.
  9. Make sure the project runs as expected.

Notes

I followed the official migration guides:

Closes #278

@nickspaargaren nickspaargaren changed the title Fix typescript issues closes #278 Fix typescript issues Sep 4, 2024
@nickspaargaren nickspaargaren mentioned this pull request Sep 9, 2024
@nickspaargaren
Copy link
Author

@thanasis457, do you still want to take a look at this? #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript issues
1 participant