Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript issues #278

Closed
thanasis457 opened this issue Sep 3, 2024 · 3 comments · May be fixed by #281
Closed

Typescript issues #278

thanasis457 opened this issue Sep 3, 2024 · 3 comments · May be fixed by #281

Comments

@thanasis457
Copy link
Contributor

Description

Fix the Sentry and ConnectedRouter errors that are due to type errors

@thanasis457 thanasis457 self-assigned this Sep 4, 2024
@thanasis457 thanasis457 removed their assignment Sep 8, 2024
@nickspaargaren
Copy link

@thanasis457, I don't think these errors are fixed yet. That's why i recently opened #281. You might want to take a look at this PR.

@thanasis457
Copy link
Contributor Author

thanasis457 commented Sep 9, 2024

@nickspaargaren Thank you so much for your PR! I seriously appreciate your help. We are a student org helping out non-profits and any help is much appreciated.

I did run the project and indeed new errors have started popping up. This is a pretty old project and a lot of the issues will only be resolved by a massive upgrade of the packages. For now, I have identified the few packages that were causing the issues and will change the package.json file to limit upgrades to patches (no minor updates since those were introducing TS issues).

There are a lot more features to be implemented so upgrading packages is not really a priority now.

@nickspaargaren
Copy link

You are welcome @thanasis457! Sounds like a helpful project!
I've already did some major dependency upgrades last week for you to resolve the newly introduced errors. Check it out and let me know if i need to explain anything else. Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants