some humble improvements #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @GMHadou ,
great that you made the ROS2 gmapping work for the humble. I took your implementation and added a few improvements so that it is more close to the original implementation (ROS1). For example, I changed all the hard coded parameters to ROS parameters.
I was thinking of directly making a PR at the original repo. However, I noticed that you already made a PR there Project-MANAS#14. So I am not sure how it's best to proceed. I have some suggestions:
every option is ok for me, do as you like. BTW, you may change the branch's name to humble. And for your PR as well. Or suggest the maintainers of the original repo to merge your PR into a new "humble" branch.
-- Alex