-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] feat: Step 3 logic #52954
Draft
MrMuzyk
wants to merge
55
commits into
Expensify:main
Choose a base branch
from
callstack-internal:feat/step-3-logic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[NO QA] feat: Step 3 logic #52954
+1,056
−726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-api-integration' into feat/step-3-logic # Conflicts: # src/libs/API/types.ts
…-api-integration' into feat/step-3-logic
…with isCreateCorpayBankAccount flag
… update corpayFields structure
…n Confirmation component
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…tep with TextLink
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Implements validation, API, navigation and other logic for step 3 in global reimbursements flow
Fixed Issues
$ #50905
PROPOSAL:
Tests
Change workspace currency to EUR, GBP, CAD or AUD
Enable workflows for the workspace
Open workflows
Try to connect a bank account
Go to the third step
Fill out all the forms and send data
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.safari.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4