Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR Phase 3] Step 4 - navigation, default data, logic and API call to save it #50906

Open
madmax330 opened this issue Oct 16, 2024 · 3 comments
Assignees
Labels

Comments

@madmax330
Copy link
Contributor

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.bos41kdplqti

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Nov 28, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Dec 16, 2024

In order to finish this issues the following needs to happen:

  • [NO QA] feat: Step 3 logic #52954 has to get merged (Step 3)
  • Data send in previous steps has to be saved in onyx
  • Final labels and translations for Upload documents screen are needed (right now we have placeholder texts from mockups)

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Dec 20, 2024

I will be OOO from 21.12 - 06.01. Latest update for this issue:

  • It is still waiting on [NO QA] feat: Step 3 logic #52954 to get merged
  • similar to step 3, BE changes are needed - data send in previous and this step has to be saved in reimbursementAccount onyx entry so it can be persisted when user logs out
  • Final labels and translations for Upload documents screen are needed (right now we have placeholder texts from mockups) are still needed
  • All data that has to be saved in BE is being gathered now, however actual API call has to be updated - we need to agree on param names and error handling has to be added on FE side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants