[NoQA] Added Workspace_Downgrade route #51518

jayeshmangwani · 2024-10-26T06:54:18Z

Details

Fixed Issues

$ #51486
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-10-26T06:54:23Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2024-10-26T06:57:10Z

@eVoloshchak C+ review will not needed here

jayeshmangwani · 2024-10-26T06:58:06Z

@carlosmiceli @DylanDylann Added the route for Workspace Downgrade in this PR. For testing and recording purposes, I included a downgrade button in the videos only (not in the PR 😃)

src/languages/es.ts

DylanDylann · 2024-10-28T16:17:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2024-10-29T03:48:04Z

@jayeshmangwani Please add downgrade page to here

App/src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts

Line 5 in db592c9

    
           [SCREENS.WORKSPACE.PROFILE]: [SCREENS.WORKSPACE.NAME, SCREENS.WORKSPACE.ADDRESS, SCREENS.WORKSPACE.CURRENCY, SCREENS.WORKSPACE.DESCRIPTION, SCREENS.WORKSPACE.SHARE],

DylanDylann · 2024-10-29T04:11:46Z

The rest looks fine to me

jayeshmangwani · 2024-10-29T04:25:10Z

Thanks for the review @DylanDylann , I've added downgrade Screen to RHP mapping

jayeshmangwani · 2024-10-29T04:26:46Z

@carlosmiceli Is there another way to confirm the translations for the downgrade page header title? I’ve already opened a Slack conversation about it, but there hasn’t been any update.

carlosmiceli · 2024-10-29T19:42:34Z

@jayeshmangwani let's ask @jamesdeanexpensify what's the best way to proceed in that case!

jamesdeanexpensify · 2024-10-29T19:44:16Z

Can you link me to the Slack conversation? Thanks!

jayeshmangwani · 2024-10-29T19:51:56Z

Yea, tagged you in Slack

jayeshmangwani · 2024-10-29T20:16:51Z

@carlosmiceli @DylanDylann PR is ready for review again. The Spanish copy has been confirmed

DylanDylann · 2024-10-30T01:24:12Z

@jayeshmangwani Reassure Performance Tests failed

jayeshmangwani · 2024-10-30T06:50:45Z

@DylanDylann I'm not sure why the Reassure Performance Tests failed. I've merged main to see if that resolves the issue

DylanDylann

@carlosmiceli All yours

carlosmiceli · 2024-10-30T15:37:47Z

Let's remove the workspace downgrade page from this PR into the PR(s) for the issue it belongs, though: #51494 (comment)
Mentioned here too: #51494 (comment)

DylanDylann · 2024-10-30T15:41:01Z

Almost done here, I think we can merge this PR first. Then I can open another PR and build on top of this PR.

jayeshmangwani · 2024-10-30T15:48:19Z

Let's remove the workspace downgrade page from this PR

Cool, I’ve removed the workspace downgrade page from this PR.

carlosmiceli · 2024-10-30T16:10:17Z

Thanks! @DylanDylann not sure if you need to review it again for this count for you? If not I can review/merge.

DylanDylann · 2024-10-30T16:14:20Z

@carlosmiceli All yours

OSBotify · 2024-10-30T16:27:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-31T11:41:45Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-04T14:14:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

added Workspace_Downgrade route

7c73cd1

jayeshmangwani requested a review from a team as a code owner October 26, 2024 06:54

melvin-bot bot requested review from eVoloshchak and removed request for a team October 26, 2024 06:54

jayeshmangwani commented Oct 26, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

jayeshmangwani added 2 commits October 28, 2024 14:14

Merge branch 'main' into Workspace_Downgrades_Route_Implementation

b303cf5

updated workspace downgrade title

a167c20

jayeshmangwani added 2 commits October 29, 2024 09:43

Merge branch 'main' into Workspace_Downgrades_Route_Implementation

6fbcac2

added workspace downgrade to workspace profile RHP mapping

b1eee9d

DylanDylann approved these changes Oct 29, 2024

View reviewed changes

melvin-bot bot requested a review from carlosmiceli October 29, 2024 04:19

jayeshmangwani added 2 commits October 30, 2024 01:33

Merge branch 'main' into Workspace_Downgrades_Route_Implementation

e8b1fe7

updated spanish copy for downgrade title

5b7010d

DylanDylann approved these changes Oct 30, 2024

View reviewed changes

Merge branch 'main' into Workspace_Downgrades_Route_Implementation

bb9865c

DylanDylann approved these changes Oct 30, 2024

View reviewed changes

carlosmiceli mentioned this pull request Oct 30, 2024

Create components for Workspace Downgrade #51494

Closed

Merge branch 'main' into Workspace_Downgrades_Route_Implementation

711debe

removed downgrade page this PR

5bb4ab1

DylanDylann approved these changes Oct 30, 2024

View reviewed changes

carlosmiceli approved these changes Oct 30, 2024

View reviewed changes

carlosmiceli merged commit 780a236 into Expensify:main Oct 30, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 31, 2024

Deploy Checklist: New Expensify 2024-10-31 #51778

Closed

melvin-bot bot mentioned this pull request Nov 4, 2024

[HOLD for payment 2024-11-11] Implement the route for Workspace Downgrades #51486

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] Added Workspace_Downgrade route #51518

[NoQA] Added Workspace_Downgrade route #51518

jayeshmangwani commented Oct 26, 2024

melvin-bot bot commented Oct 26, 2024

jayeshmangwani commented Oct 26, 2024

jayeshmangwani commented Oct 26, 2024

DylanDylann commented Oct 28, 2024 •

edited

Loading

DylanDylann commented Oct 29, 2024

DylanDylann commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

carlosmiceli commented Oct 29, 2024

jamesdeanexpensify commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

DylanDylann commented Oct 30, 2024

jayeshmangwani commented Oct 30, 2024

DylanDylann left a comment

carlosmiceli commented Oct 30, 2024 •

edited

Loading

DylanDylann commented Oct 30, 2024

jayeshmangwani commented Oct 30, 2024

carlosmiceli commented Oct 30, 2024

DylanDylann commented Oct 30, 2024

OSBotify commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

[NoQA] Added Workspace_Downgrade route #51518

[NoQA] Added Workspace_Downgrade route #51518

Conversation

jayeshmangwani commented Oct 26, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 26, 2024

jayeshmangwani commented Oct 26, 2024

jayeshmangwani commented Oct 26, 2024

DylanDylann commented Oct 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Oct 29, 2024

DylanDylann commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

carlosmiceli commented Oct 29, 2024

jamesdeanexpensify commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

jayeshmangwani commented Oct 29, 2024

DylanDylann commented Oct 30, 2024

jayeshmangwani commented Oct 30, 2024

DylanDylann left a comment

Choose a reason for hiding this comment

carlosmiceli commented Oct 30, 2024 • edited Loading

DylanDylann commented Oct 30, 2024

jayeshmangwani commented Oct 30, 2024

carlosmiceli commented Oct 30, 2024

DylanDylann commented Oct 30, 2024

OSBotify commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

DylanDylann commented Oct 28, 2024 •

edited

Loading

carlosmiceli commented Oct 30, 2024 •

edited

Loading