Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create components for Workspace Downgrade #51494

Open
carlosmiceli opened this issue Oct 25, 2024 · 32 comments
Open

Create components for Workspace Downgrade #51494

carlosmiceli opened this issue Oct 25, 2024 · 32 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@carlosmiceli
Copy link
Contributor

carlosmiceli commented Oct 25, 2024

Part of Add Workspace Plan Downgrades to NewDot

Doc section

Steps to complete:

  • Update Workspace Profile Page
  • Create Plan Type RHP
  • Create Downgrade Confirmation RHP
  • Create Downgrade Success RHP
  • Create Downgrade Success RHP for admins of other Control workspaces
Issue OwnerCurrent Issue Owner: @DylanDylann
@carlosmiceli carlosmiceli added NewFeature Something to build that is a new item. Daily KSv2 labels Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@DylanDylann
Copy link
Contributor

DylanDylann commented Oct 29, 2024

@carlosmiceli Could we divide this issue into multiple PRs?

cc @jasperhuangg

@DylanDylann
Copy link
Contributor

DylanDylann commented Oct 29, 2024

@carlosmiceli

I notice that we need to create these tasks:

  • Create Plan Type Page
  • Create a generic success component
  • Upgrade #admins messaging and workspace owner whisper

@carlosmiceli
Copy link
Contributor Author

Sorry about the delay, have been sick the last couple of days 🙏

I don't see why not have multiple PRs if you think that's best.

@carlosmiceli
Copy link
Contributor Author

@DylanDylann isn't the success component the same as the confirmation component?

When you say plan type page, do you mean the workspace downgrade page? Btw, I think @jayeshmangwani already put that page together on the other PR, but since it's a PR about routes I think it shouldn't be included there. Can we move that into a the new PR that Dylan is going to work on so it's better organized according to the issues' scopes?

I'll create an issue about upgrades soon, but let me get back to you on that later this week 👍

@DylanDylann
Copy link
Contributor

DylanDylann commented Oct 30, 2024

@carlosmiceli In downgrade flow, we have 4 sections

  1. This is the plan type page
Screenshot 2024-10-30 at 17 56 46
  1. This is the workspace downgrade page
Screenshot 2024-10-30 at 17 57 10
  1. This is the confirm/success page (confirm page and success page are same 😄 )
Screenshot 2024-10-30 at 17 58 03
  1. Handle downgrade message in admin room
Screenshot 2024-10-30 at 17 59 03

@DylanDylann
Copy link
Contributor

@carlosmiceli And in this issue, we will implement:

  • The plan type page
  • The downgrade page
  • The confirm/success page

@dannymcclain
Copy link
Contributor

Not sure if it's helpful or not, but the downgrade page and confirm/success page follow the same pattern/layout as our upgrade equivalent of those screens. So ideally we could reuse a lot of styles from those upgrade screens that are already built.

@carlosmiceli
Copy link
Contributor Author

@dannymcclain Thanks Danny, good idea!

@DylanDylann Yes, let's handle those three elements on this issue. We need to move the downgrade page from this PR into your PR(s) though, so it's better organized. cc @jayeshmangwani

@DylanDylann
Copy link
Contributor

Sure 🚀

@carlosmiceli
Copy link
Contributor Author

@DylanDylann thanks for checking me on the issue description, I just updated it according to this section and images in the doc, I think this will be clearer: https://docs.google.com/document/d/1GDPmbvV47VVxucr-tHYjH80VylcJptP0RfGMVy3zanY/edit?tab=t.0#bookmark=id.mnt3pa1wzv

It's 5 items now (do it in as many PRs as you'd like), I'll create another issue for the messaging portion.

@carlosmiceli carlosmiceli added Daily KSv2 and removed Weekly KSv2 labels Oct 30, 2024
@DylanDylann
Copy link
Contributor

I am woking on PR, try to open PR on Friday

@carlosmiceli
Copy link
Contributor Author

Great, thanks sir! I'll be ready to look at it today or during the weekend, let me know if you need anything :)

@DylanDylann
Copy link
Contributor

Let's me know when the Downgrade API is done. Thanks

@jayeshmangwani
Copy link
Contributor

You can raise a FE changes PR so I can use that page for the locked type. Please go ahead with the FE changes, and we can implement the BE later. What do you think, @carlosmiceli ?

@DylanDylann
Copy link
Contributor

It required another PR to integrate API. Please create a PR for #51768 and include the plan type on your PR.

When the API is done, I will raise PR for this issue and #51764

@DylanDylann
Copy link
Contributor

@jayeshmangwani Let's make it flexible to process the project asap

@jayeshmangwani
Copy link
Contributor

Sounds good! I'll implement this in the PR today.

@jayeshmangwani
Copy link
Contributor

Let's make it flexible to process the project asap

@DylanDylann sorry I didn't get this, I have blocked you in any way

@jayeshmangwani
Copy link
Contributor

@DylanDylann You mentioned you were going to implement this page, so I should wait for you, right?

@garrettmknight
Copy link
Contributor

Small update, I just realized that the copy in the Figma doesn't match the copy we agreed on in the doc for the Plan type RHP. Can we update to:

Choose a plan that's right for you. For a detailed list of features and pricing, check out our plan types and pricing help page.

Additionally, we slightly updated the URL to the pricing help page to https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Plan-types-and-pricing

Screenshot 2024-11-07 at 12 21 52 PM

@jayeshmangwani
Copy link
Contributor

Can we update to:
Choose a plan that's right for you. For a detailed list of features and pricing, check out our plan types and pricing help page.

Sure, will update this copy and URL

@DylanDylann
Copy link
Contributor

@carlosmiceli Have we completed API for Workspace downgrade?

@carlosmiceli
Copy link
Contributor Author

Hey @DylanDylann sorry for being a bit delayed here, there are no updates yet because I'm tied down with a couple of critical issues. I'd definitely suggest to get the FE work done as advanced as possible before needing the API requests to work fully, so we can get a bit ahead. Do you need everything ready from the BE to make progress here?

@carlosmiceli
Copy link
Contributor Author

The BE logic is in review, will notify once it's merged so this can be properly tested.

@DylanDylann
Copy link
Contributor

@carlosmiceli Any update on the BE changes

@carlosmiceli
Copy link
Contributor Author

It's under review, hopefully merged soon! 🙏

@carlosmiceli
Copy link
Contributor Author

Final BE PR has been merged :)

@DylanDylann DylanDylann mentioned this issue Dec 19, 2024
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

6 participants