-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create components for Workspace Downgrade #51494
Comments
Triggered auto assignment to @twisterdotcom ( |
|
Triggered auto assignment to Design team member for new feature review - @dannymcclain ( |
@carlosmiceli Could we divide this issue into multiple PRs? |
I notice that we need to create these tasks:
|
Sorry about the delay, have been sick the last couple of days 🙏 I don't see why not have multiple PRs if you think that's best. |
@DylanDylann isn't the success component the same as the confirmation component? When you say plan type page, do you mean the workspace downgrade page? Btw, I think @jayeshmangwani already put that page together on the other PR, but since it's a PR about routes I think it shouldn't be included there. Can we move that into a the new PR that Dylan is going to work on so it's better organized according to the issues' scopes? I'll create an issue about upgrades soon, but let me get back to you on that later this week 👍 |
@carlosmiceli In downgrade flow, we have 4 sections
|
@carlosmiceli And in this issue, we will implement:
|
Not sure if it's helpful or not, but the downgrade page and confirm/success page follow the same pattern/layout as our upgrade equivalent of those screens. So ideally we could reuse a lot of styles from those upgrade screens that are already built. |
@dannymcclain Thanks Danny, good idea! @DylanDylann Yes, let's handle those three elements on this issue. We need to move the downgrade page from this PR into your PR(s) though, so it's better organized. cc @jayeshmangwani |
Sure 🚀 |
@DylanDylann thanks for checking me on the issue description, I just updated it according to this section and images in the doc, I think this will be clearer: https://docs.google.com/document/d/1GDPmbvV47VVxucr-tHYjH80VylcJptP0RfGMVy3zanY/edit?tab=t.0#bookmark=id.mnt3pa1wzv It's 5 items now (do it in as many PRs as you'd like), I'll create another issue for the messaging portion. |
I am woking on PR, try to open PR on Friday |
Great, thanks sir! I'll be ready to look at it today or during the weekend, let me know if you need anything :) |
Let's me know when the Downgrade API is done. Thanks |
You can raise a FE changes PR so I can use that page for the locked type. Please go ahead with the FE changes, and we can implement the BE later. What do you think, @carlosmiceli ? |
@jayeshmangwani Let's make it flexible to process the project asap |
Sounds good! I'll implement this in the PR today. |
@DylanDylann sorry I didn't get this, I have blocked you in any way |
@DylanDylann You mentioned you were going to implement this page, so I should wait for you, right? |
Small update, I just realized that the copy in the Figma doesn't match the copy we agreed on in the doc for the Plan type RHP. Can we update to:
Additionally, we slightly updated the URL to the pricing help page to https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Plan-types-and-pricing |
Sure, will update this copy and URL |
@carlosmiceli Have we completed API for Workspace downgrade? |
Hey @DylanDylann sorry for being a bit delayed here, there are no updates yet because I'm tied down with a couple of critical issues. I'd definitely suggest to get the FE work done as advanced as possible before needing the API requests to work fully, so we can get a bit ahead. Do you need everything ready from the BE to make progress here? |
The BE logic is in review, will notify once it's merged so this can be properly tested. |
@carlosmiceli Any update on the BE changes |
It's under review, hopefully merged soon! 🙏 |
Final BE PR has been merged :) |
Part of Add Workspace Plan Downgrades to NewDot
Doc section
Steps to complete:
Issue Owner
Current Issue Owner: @DylanDylannThe text was updated successfully, but these errors were encountered: