Unable to toggle per diem off after downgrading

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11 pro/chrome
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Navigate to More features
4. Enable per diem and upgrade to control
5. Go to workspace profile > Plan
6. Downgrade to collect
7. Go to more features
8. Disable Per diem

Expected Result:

User is able to toggle off per diem

Actual Result:

User is unable to toggle off per diem

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701574_1735003926155.bandicam_2024-12-24_04-29-35-934.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Offending PR:
#54356

Solution

• We can solve it by disabling all the control features when the user downgrade the plan (need BE changes inside the DowngradeAPI or invoking the feature api one by one) and also we need to handle optimistic, success and failure onyx data
• Inside the features tab i.e WorkspaceInitalPage, workspacemorefeaturespage we will enable the feature if the plan is control plan
  

  App/src/pages/workspace/WorkspaceInitialPage.tsx

  Line 125 in 8b7096f

  [CONST.POLICY.MORE_FEATURES.ARE_PER_DIEM_RATES_ENABLED]: policy?.arePerDiemRatesEnabled,

  
  We can do this for all control feature

[DylanDylann]

@NJ-2020 Thanks for your input.

@carlosmiceli I think we need to fix this on the BE side. We need to disable all features on the control plan if the user downgrades plan. I don't think we need to update optimistic data as mentioned on design doc

[techievivek]

Going to assign this to @carlosmiceli since he seems to be working on the doc.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[carlosmiceli]

@DylanDylann thank you, seems like we missed this on the design doc, looking into it now! 🙏

[jasperhuangg]

Since this is a back-end error I'm applying the relevant labels.

[carlosmiceli]

PR fix is in review.

Screen.Recording.2024-12-25.at.3.48.25.AM.mov

[carlosmiceli]

PR above is merged, but one more PR was needed, also under review.

[techievivek]

Removing the blocker label since the feature is under beta.