Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-02] Hook up with the Downgrade Workspace API #51515

Open
carlosmiceli opened this issue Oct 26, 2024 · 30 comments
Open
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@carlosmiceli
Copy link
Contributor

carlosmiceli commented Oct 26, 2024

Part of Add Workspace Plan Downgrades to NewDot

Doc section

Steps to complete:

  • Create a new action
  • Connect it with the downgrade button
Issue OwnerCurrent Issue Owner: @sonialiap
@carlosmiceli carlosmiceli added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 26, 2024
@carlosmiceli carlosmiceli self-assigned this Oct 26, 2024
@carlosmiceli carlosmiceli added Weekly KSv2 and removed Daily KSv2 labels Oct 26, 2024
Copy link

melvin-bot bot commented Oct 26, 2024

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 26, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Oct 26, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@carlosmiceli carlosmiceli changed the title Hook up with the Downgrade Workspace API [HOLD] Hook up with the Downgrade Workspace API Oct 28, 2024
@carlosmiceli
Copy link
Contributor Author

This will be the final issue to complete, so it needs to HOLD on all the other issues from the project. Will assign contributor then.

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@shawnborton
Copy link
Contributor

I think we're still holding on this one, right?

@carlosmiceli
Copy link
Contributor Author

Will try to make progress today.

@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
@carlosmiceli
Copy link
Contributor Author

We are close to being able to do this, final BE PR is in review and we can start testing FE and BE together.

@carlosmiceli
Copy link
Contributor Author

Hey @DylanDylann, this should be ready to tackle now that the BE is complete :)

@carlosmiceli carlosmiceli changed the title [HOLD] Hook up with the Downgrade Workspace API Hook up with the Downgrade Workspace API Nov 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@sonialiap
Copy link
Contributor

@DylanDylann this feature is ready for the FE part! Will you be able to handle this one?

@carlosmiceli carlosmiceli added Daily KSv2 and removed Weekly KSv2 labels Dec 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 9, 2024
@DylanDylann
Copy link
Contributor

@carlosmiceli Yeah I already did the FE implementation locally with a branch built up from #53343. I will raise PR after #53343 is merged

@carlosmiceli
Copy link
Contributor Author

Great!

@sonialiap
Copy link
Contributor

I'm OOO Dec 16-20, I don't think this will need a BZ before I'm back, but if it does please reapply the bug label

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

@carlosmiceli, @shawnborton, @sonialiap, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@carlosmiceli
Copy link
Contributor Author

Not overdue, we're working on it :D

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
@carlosmiceli
Copy link
Contributor Author

@DylanDylann I think I found the issue with the duplicate action, but can we proceed using the first one while I try to fix it?

@carlosmiceli
Copy link
Contributor Author

Fixed, will be merged soon. The action that says this workspace instead of the policy name is the right one.

@DylanDylann
Copy link
Contributor

Please ping me when the change is deployed

@carlosmiceli
Copy link
Contributor Author

It's now deployed.

@DylanDylann
Copy link
Contributor

@carlosmiceli Worked well

Screenshot 2024-12-19 at 11 39 05

@carlosmiceli
Copy link
Contributor Author

Fantastic, thanks sir! cc @garrettmknight

I'll go over all the open issues tomorrow to see what's left to do, but anything outstanding from your end @DylanDylann ?

@DylanDylann
Copy link
Contributor

Everything works well from me

@carlosmiceli
Copy link
Contributor Author

To confirm, this is still the plan, correct?

@DylanDylann DylanDylann mentioned this issue Dec 19, 2024
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 19, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 26, 2024
@melvin-bot melvin-bot bot changed the title Hook up with the Downgrade Workspace API [HOLD for payment 2025-01-02] Hook up with the Downgrade Workspace API Dec 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @DylanDylann requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 26, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

4 participants