Deploy Checklist: New Expensify 2024-12-23

[github-actions]

Release Version: 9.0.78-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix wallet phone validation page #52082
• Update correct next approver with category/tag rules #52537
• [vip-travel] Create Trip Details Screen #52823
• [No QA] Fix CREATE mutations being dropped by merging transactions #53313
• Apply tax rule when selecting category #53332
• WS plan type and upgrade common features view Pages #53343
• fix: when selecting categories, the selected categories get reset #53519
• fix: some member appear as Hidden #53540
• Implemented Edit/Delete Per diem rates #53625
• replace FlatList with .map solution #53655
• Fix badly positioned screen with autofocus #53699
• fix: Make all task titles/descriptions read-only to all but the author/assignee. #53749
• [NoQA] fix: bottom tab transitions duration #53754
• fix: enable paste html in compose box and fix regressions #53758
• improvement: Add "Workspace" to Profile and Name at the workspace level for clarity. #53800
• Fix: Remove GBR and 'Add a bank account' for paid invoices #53802
• fix: displaying header for group chat #53847
• Fix - Tags - In expense report, full tag name is not shown in tag list page #53940
• Fix - Concierge - Concierge header has extra bottom padding #53942
• Fix - Held expense - Hold option is missing when submitting expense to workspace offline as employee #53944
• Fix - QAB- QAB navigates to last opened expense type rather than summited expense #53945
• Can't add new report actions in Debug mode #53969
• fix: show empty search view when search API return error #54007
• fix: WS switcher blank screen, keep workspace history #54030
• Fix new member added while offline doesn't show in approval flow list #54105
• Fix - Search - App redirects to DM when submitting expense in Search after deleting expense #54109
• Remove ReportUtils.getReport method export #54113
• Replace all explicit hidden comparisons with isHiddenParticipant() #54146
• FIX: Two QA guide entries in the member list after onboarding with Manage my team's expenses #54147
• [No QA][HybridApp] Add standalone installation scripts to NewDot repo #54190
• [Performance] Update useReportIDs to check draft amount #54191
• Revert "Revert "Contacts import"" #54209
• fix: update here link in suspended account message #54230
• Fix: new workspace button is overlapped by keyboard #54231
• Fix invoice thread isn't deleted when dismissing create error #54232
• Fix new line doesn't move to the next msg when the unread msg is deleted #54233
• Fix issue where selected invited new user becomes unselected when ret… #54237
• Fix: Android - Category - "Default tax rate" briefly changes back to the default one #54239
• fix metro config and patch draggable flat list #54245
• Update react-fast-pdf to use modern pdfjs-dist #54250
• Fix extra spaces below list footer #54255
• Adding images to the Create-an-expense article #54262
• fix: manage modal closing #54279
• [No QA] chore: apply npm audit fix to resolve high security vulns #54286
• [No QA] Add more files to eslint changed check exceptions list #54288
• Fix keyboard blinks #54293
• remove lastMessageTranslationKey from report collection #54295
• [No QA] Adhoc builds follow ups #54299
• [No QA] Update Expensify-API.md #54330
• Fix the step numbers in a doc page #54332
• [NoQA] Fix size translations #54342
• Remove isArray checks for onboarding #54353
• [No QA] Patch failed to be applied but succeeded message is shown #54355
• Downgrade Feature #54356
• fix: Desktop - The search filter shifts to the window border on scroll #54359
• [No QA] Disable prettier in Mobile-Expensify submodule #54360
• Hide margin if no delegators #54368
• [NO QA] Revert "Merge pull request #54150 from nyomanjyotisa/issue-53980" #54386
• Update Configure-Netsuite.md #54390
• Update SAML-SSO.md #54392
• Revert "fix: clicking submit button makes flicking on a workspace with delay …" #54395
• Fix chat isn't scrolled to bottom automatically after paying #54401
• [CP Staging][NO QA] Revert "[No QA] Adhoc builds follow ups" #54402
• Fix - Hold - Hold banner shows up after deleting dupe expense #54408
• Revert "Revert "Revert "Contacts import""" #54421
• navigate to Referral modal when click get $250 #54445
• [CP staging] Fix the HeaderWithBackButton compnent so that icons take their natural fill color #54494
• [CP staging] fix: go back to LHN page #54511
• [CP Staging] Fix illustration styling for empty view #54577
• Revert "fix: when selecting categories, the selected categories get reset" #54583
• Revert "fix wallet phone validation page" #54585

Internal QA:

• [Internal QA]: Fixes for Sage connection and Xero #54411 - @mountiny

Deploy Blockers:

• [$250] Composer - "Split expense" and "Create expense" options only appear after a delay #54327
• [HOLD for payment 2025-01-02] Icons are decolorized in security  #54480
• [$250] Taxes - "1 selected" dropdown is not dismissed after the selected rate is deleted #54485
• Category - Selected item is no longer selected after renaming the category #54486
• [HOLD for payment 2025-01-02] Wallet - "phone number is not valid email address" error when activating card with phone number #54487
• Per diem - RHP shows offline view when deleted, fields are not grayed out when edited offline #54488
• Invite member - App freezes for some seconds when opening Invite member list #54489
• Infinite loading on downgrade button if a secondary admin tries to downgrade plan #54493
• Preselected marker on RHP doesn't change dynamically for the secondary admin #54495
• [HOLD for payment 2025-01-02] Chat- Back button from expense detail leads to LHN rather than expense report conversation #54496
• Category- RHP doesn't opened after selecting categories and navigate to a single #54497
• Selection gets removed after navigating to a single per diem option #54498
• Unable to toggle per diem off after downgrading #54499
• Per diem - Amount cannot be cleared when there is negative sign #54500
• [$250] Web - Blue selection border on plan option after a refresh #54502
• Workspace - No "Plan type" field for upgrading or downgrading workspace on iOS #54503
• mWeb/Safari - Chat - New message button appears in the chat for the messages sender #54504
• iOS - App briefly shows blank page when returning to LHN after opening DM from FAB #54505
• Features behind a paywall are accessible after downgrading #54506
• [HOLD for payment 2025-01-02] Expense - From expense report page tapping app's back button navigated to Workspace chat page #54508
• Web - LHN - Workspace switcher resets to Expensify when sending invoice for the first time #54509
• [$250] Expense-App shows not here page instead of auto refresh report when exchanging expense offline #54512
• Distance - Inconsistency in Tax field when both distance rate and category have different tax #54513
• New icons are corrupted #54514
• Tax rate - System message does not show the correct tax rate when category has tax rate #54515
• [HOLD for payment 2025-01-02] mWeb - Workspace - Using back button on WS chat, leads to inbox instead of WS profile. #54517
• iOS - Workspace plan - Nothing happens when selecting Collect plan and tapping Save button #54523
• Workspace plan - "Collect" is not translated to Spanish #54525
• Copilot - App freeze when adding a copilot #54529
• Trip - No "Cancellation policy" field in the car trip details #54536
• [$250] Trip - Trip details RHP opens instead of not here page when opening invalid trip link #54537
• Trip- No option to copy Modify trip or Trip support external link when right-click on the link #54540
• Trip - Modify trip and Trip support button open the same page #54545
• Search - App freezes when using search #54553
• Expense - Inconsistency in category and tax change system message when editing category #54559
• Expense - Report action shows "changed tax rate to x(previously x)" when there is no rate change #54560
• [HOLD for payment 2025-01-02] Track expense - Illustration in the empty state recipient list is top-aligned and not centered #54564

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Beamanator]

Checking off #54500 as known issue, NAB as it's a brand new feature

[izarutskaya]

Regression is 64 % completed
We still don't have Hybrid Android build

Unchecked PRs:
#53519 - Failing with #53519 (comment)
#53800 - Failing with #53800 (comment) on iOS app
#54230 - Failing with #54230 (comment)
#54237 - Found issue #54237 (comment)

DB:
#54327
#54480
#54486
#54487
#54488
#54489
#54493
#54496
#54497
#54498
#54499
#54502
#54503
#54504

[cristipaval]

Checking off #54502

[jasperhuangg]

@izarutskaya I sent the newest APK to the thread on Slack, let me know if you need anything else. I'm still diagnosing why the version on the Google Play Store for testers is wrong.

[jasperhuangg]

Demoted #54537 #54540 and #54545

[Beamanator]

Checked off #54496 as also fixed by #54511

[izarutskaya]

Regression is 2 % left

Unchecked PRs:
#52823 - Failing with #52823 (comment)
#53519 - Failing with #53519 (comment) Closed as expected. Can I check off?
#53800 - Failing with #53800 (comment) on iOS app
#54030 - Failing on mWeb with #54030 (comment)
#54230 - Failing with #54230 (comment)
#54237 - Found issue #54237 (comment)
#54408 - Found issue #54489 Closed with comment
#54445 - Failing on iOS Hybrid only with #54445 (comment) Repro in PROD

DB:
#54480
#54486
#54487
#54488
#54513
#54515
#54529
#54536

[kavimuru]

Regression is completed.
Unchecked PRs:
#52823 - Failing with #52823 (comment)
#53519 - Failing with #53519 (comment) Closed as expected. Can I check off?
#53800 - Failing with #53800 (comment) on iOS and Android
#53944 failing in Android with original fixed issue #53944 (comment)
#54030 failing with #54527 repro in PROD checking it off
#54147 failing in android and iOS with #54563 repro in PROD checking it off
#54230 - Failing with #54230 (comment)
#54245 (comment)
#54356 (comment)
#54408 failing with #54489
#54445 failing with #54526 and repro in PROD, checking it off

Open blockers:
#54480
#54486
#54487
#54488
#54513
#54515
#54536
#54529
#54559
#54560
#54564

[Beamanator]

Checked off #54559 as NAB as discussed in slack here

[neil-marcellini]

Checking off #54486

[os-botify]

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

[melvin-bot]

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jasperhuangg]