Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-02] [$250] Android - Crash when kill the app and reopen it #50463

Open
1 of 6 tasks
lanitochka17 opened this issue Oct 8, 2024 · 59 comments
Open
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Install the New dot app
  2. Open android app
  3. Login with new gmail account
  4. Complete the onboarding modal
  5. Kill the app
  6. Open the app

Expected Result:

App should open

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6628394_1728395962594.Recording__4245.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021843775413325774813
  • Upwork Job ID: 1843775413325774813
  • Last Price Increase: 2024-11-19
  • Automatic offers:
    • DylanDylann | Reviewer | 105060601
    • shubham1206agra | Contributor | 105341816
Issue OwnerCurrent Issue Owner: @kadiealexander
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@srikarparsi
Copy link
Contributor

Not able to reproduce on my physical ios device with a new account. Going to try on android emulator.

@thienlnam
Copy link
Contributor

thienlnam commented Oct 8, 2024

There's been an emerging crash in firebase that looks like it might be related here
com.expensify.chat_issue_4f8a216f0a769e684d009b28ef9bd7d4_crash_session_6705473302F5000179E748FD60E92734_DNE_0_v2_stacktrace.txt

SurfaceMountingManager.getViewState

Appears to be present in a few different versions, so maybe not a deploy blocker

@thienlnam
Copy link
Contributor

Potentially related: facebook/react-native#38743

@thienlnam
Copy link
Contributor

@kirillzyusko Do you think this #37891 would address this crash as well?

@thienlnam thienlnam changed the title Android - Crash when kill the app and reopen it [HOLD #50482] Android - Crash when kill the app and reopen it Oct 8, 2024
@thienlnam thienlnam added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 8, 2024
@srikarparsi
Copy link
Contributor

I'm not able to reproduce on an emulator in production
https://github.com/user-attachments/assets/7a55635c-6cfa-4014-8dc1-3d6b43938a9d

@srikarparsi
Copy link
Contributor

I am able to reproduce on staging. But reopening the app does work so it doesn't continually crash. Future quit/reopens don't crash the app either.
https://github.com/user-attachments/assets/ca340a7e-ccd4-417d-93d6-916f02cd59a8

@thienlnam
Copy link
Contributor

Hmm, this crash has been happening quite a bit - perhaps we can get some eyes on this?

@thienlnam thienlnam added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Current assignee @srikarparsi is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@thienlnam thienlnam changed the title [HOLD #50482] Android - Crash when kill the app and reopen it Android - Crash when kill the app and reopen it Oct 8, 2024
@melvin-bot melvin-bot bot changed the title Android - Crash when kill the app and reopen it [$250] [HOLD #50482] Android - Crash when kill the app and reopen it Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021843775413325774813

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

@github-actions github-actions bot added the Hourly KSv2 label Oct 8, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Nov 25, 2024

@srikarparsi, @kadiealexander, @DylanDylann 12 days overdue. Walking. Toward. The. Light...

@muttmuure
Copy link
Contributor

@j-piasecki is going to take a look at this. @j-piasecki please can you comment?

@j-piasecki
Copy link
Contributor

Sure!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
@j-piasecki
Copy link
Contributor

I was able to reproduce the crash. I've opened an issue in the React Native repository with more details: facebook/react-native#47960

@srikarparsi
Copy link
Contributor

Closed out this issue (which has some stack traces in the issue body) in favor of this one.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

@j-piasecki, @srikarparsi, @kadiealexander, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@shubham1206agra
Copy link
Contributor

@srikarparsi Please assign me for review

Copy link

melvin-bot bot commented Dec 15, 2024

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@DylanDylann DylanDylann removed their assignment Dec 16, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 26, 2024
@melvin-bot melvin-bot bot changed the title [$250] Android - Crash when kill the app and reopen it [HOLD for payment 2025-01-02] [$250] Android - Crash when kill the app and reopen it Dec 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 26, 2024

@shubham1206agra @kadiealexander @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: CRITICAL
Development

No branches or pull requests