[$250] LOW: Investigate using native-stack on native platforms instead of stack

[mountiny]

Coming from here

When we have refactored the App navigation, we have chose to use the normal react-navigation stack as that gave us more control over animation/ transitions of pages on web. This was to also not complicate the MVP for the project with two types of stack.

The problem is that the normal stack does not lead to native feel of app page transitions in native device which makes the feel of the app worse as the page transitions are ever so slightly off compared to the other native apps you might be using on daily basis.

Its important to address this discrepancy and ideally introduce the native-stack for native iOS and Android platforms, as chat/ P2P users have high standards for native app quality.

cc @hannojg @adamgrzybowski

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866177344381113052
• Upwork Job ID: 1866177344381113052
• Last Price Increase: 2024-12-09

[hannojg]

Yes, will help investigating this or next week 🤝!

[hannojg]

PR is up:

• Perf/native stack navigation #29991

[hannojg]

We got two blockers at the minute:

• iOS 17 has bugs with the keyboard which hit in expensify once we turn on the native stack, waiting for an OS update here
• This upstream PR: feat(Android): add ios like slide animation software-mansion/react-native-screens#1945 so we have the same native transitions on android (right now the native transitions on android feel outdated)

[WoLewicki]

@hannojg as for the second dot, the ios like do you think that this animation is what people want on Android to have the native feel? Maybe we could explore the other animations that are strictly taken from the Android XMLs?

Also, could you elaborate how does native-stack improve the performance of the app exactly? One thing I can think of is native swipe to go back on iOS which is controlled by the native code, but you still need to mount the previous screen on the native side when it happens, did you check how it performs when going back to reports with many many messages?

[hannojg]

ios like do you think that this animation is what people want on Android to have the native feel

We have to double check the animation. Its called iOS like but I think it actually feels like the android default slide transition

Also, could you elaborate how does native-stack improve the performance of the app exactly

This is more about perceived performance and UX feeling. Right now you can tell by using the expensify app, that the transitions aren't the native transitions. So we want to have the native transitions so expensify feels like a native app.

you still need to mount the previous screen on the native side when it happens, did you check how it performs when going back to reports with many many messages?

Do I understand it correctly that you are suggesting that switching to native-stack could be a performance issue when doing the swipe back gesture?

[WoLewicki]

Do I understand it correctly that you are suggesting that switching to native-stack could be a performance issue when doing the swipe back gesture?

We have the same abstraction in the stack navigator, where we control the mounting/unmounting the views by using activityState prop. Native-stack should not have worse performance, I'm just curious if it is fast enough no to be laggy in high traffic accounts 😅

[mountiny]

we should test it out with high traffic accounts, the E2E tests once are built in like 2 weeks should also tell us more how it performs there

[melvin-bot]

This issue has not been updated in over 15 days. @hannojg, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

Keeping this monthly, its not high priority and still waiting on some issues to get resolved.

[melvin-bot]

@hannojg, @mountiny, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[mountiny]

@hannojg How is this looking now with latesst ios, have they fixed anything?

[mountiny]

This was merged and now its in production 🎉

[joekaufmanexpensify]

Going to issue payment here in the next day!

[mountiny]

PRs to pay out:

• Perf/native stack navigation #29991 - there was many regressions and it was reverted I think no payments required there
• [NoQA] Perf: PlatormStackNavigation - Use @react-navigation/native-stack on mobile platforms #37891 - @ishpaul777
• Migrate E/App to use PlatformStackNavigation #49937 - @ishpaul777 and @c3024

I would say $1000 to @ishpaul777 and $250 to @c3024 for their work on these

[joekaufmanexpensify]

Got it. TY! Opening new upwork job so we can pay.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866177344381113052

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[joekaufmanexpensify]

Ah, actually noticed @c3024 is already being paid for their PR here. So we just need to pay @ishpaul777

[joekaufmanexpensify]

Payment summary is $1,250 to @ishpaul777 for C+ review via upwork.

[joekaufmanexpensify]

@ishpaul777 offer sent in Upwork!

[ishpaul777]

@mountiny I also reviewed this PR: #49936. Additionally, I believe the effort and time involved in this were significant. Could we consider adjusting the bounty slightly, perhaps to $1500 for all three PRs I reviewed?

[mountiny]

@ishpaul777 ah nice, thanks for the link. Let's increase to $1250, including that PR. Thanks!

[joekaufmanexpensify]

Sounds good! Adjusted payment summary. @ishpaul777 please accept the offer I sent. I will pay the extra $250 as a bonus.

[ishpaul777]

Sounds good! Accepted offer!

[joekaufmanexpensify]

@ishpaul777 $1,250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.