[HOLD for payment 2024-10-17] [HOLD for payment 2024-06-06] [HOLD #37891] Keyboard jumps around when swiping back from chat to LHN with gesture

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.48-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @vitHoracek
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709810201224169

Action Performed:

1. Open app
2. Go to any chat
3. Tap on the composer field to keyboard open
4. Swipe from chat to LHN with gesture and leaving the keyboard open

Expected Result:

keyboard should close

Actual Result:

Keyboard jumps and then it gets disappeared

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1709838593.MP4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

Can't reproduce this one on the latest (v1.4.50-0).

Asking @mountiny to retry here: https://expensify.slack.com/archives/C049HHMV9SM/p1710155707974309?thread_ts=1709810201.224169&cid=C049HHMV9SM

[mountiny]

Noted in the Slack thread, I can still repro, it did not happen the first time but then consequently it happened reliably https://expensify.slack.com/archives/C049HHMV9SM/p1710155707974309?thread_ts=1709810201.224169&cid=C049HHMV9SM

cc @kirillzyusko

[kirillzyusko]

@mountiny should be fixed in #37891 I believe? 👀

[mountiny]

Yep, cannot repro 🎉 putting this on hold for the PR
https://github.com/Expensify/App/assets/36083550/925c8c62-8a3d-4bea-bb99-039825d48c8d

[melvin-bot]

This issue has not been updated in over 15 days. @trjExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

This should hopefully be fixed wiht the native stack after the fabric branch is merged

[kirillzyusko]

@mountiny I actually discovered an actual fix that should fix this problem - #42257

May I kindly ask you to have a look on it? 👀

[mountiny]

Amazing

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: disable KeyboardAvoidingView in bottom-tab navigator #42257

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @kirillzyusko does not require payment (Contractor)
• @vitHoracek requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@kirillzyusko] Determine if we should create a regression test for this bug.
• [@kirillzyusko] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[trjExpensify]

👋 checklist please!

[mountiny]

I dont think this requires a regression test. This is coming from when the bottom navigation was added and we have removed one prop that resolved the keyboard issue.

I think this is good to be paid out to @s77rt $250 for their review and help

[trjExpensify]

Okay! Payment summary as follows:

• @s77rt $250 for the C+ review of the PR

Offer sent!

[s77rt]

@trjExpensify Accepted! Thanks!

[trjExpensify]

Paid!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[s77rt]

False positive ^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Perf: PlatormStackNavigation - Use @react-navigation/native-stack on mobile platforms #37891

If no regressions arise, payment will be issued on 2024-10-17. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @kirillzyusko does not require payment (Contractor)
• @vitHoracek requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

The checklist above ^ is unrelated. Also #37923 (comment)