Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove total supply in genesis #191

Merged
merged 2 commits into from
Sep 19, 2024
Merged

remove total supply in genesis #191

merged 2 commits into from
Sep 19, 2024

Conversation

cloud8little
Copy link
Contributor

@cloud8little cloud8little commented Sep 19, 2024

Description


Closes #XXX

Summary by CodeRabbit

  • Bug Fixes

    • Removed the explicit setting of the token's total supply, which may improve asset initialization handling.
  • Chores

    • Updated the git package version in the Dockerfile for potential bug fixes and improvements.

Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

The changes involve modifications to the local_node.sh script and two Dockerfiles. In local_node.sh, a line that set the total_supply for a token was removed, indicating a shift in how the total supply is handled. The Dockerfiles for both the main project and Exocore have been updated to reflect a new version of the git package, changing from 2.43.4-r0 to 2.43.5-r0, without altering the overall functionality.

Changes

Files Change Summary
local_node.sh Removed the line setting total_supply to "40022689732746729" in the script.
Dockerfile, networks/local/exocore/Dockerfile Updated git package version from 2.43.4-r0 to 2.43.5-r0.

Possibly related PRs

Suggested reviewers

  • cloud8little
  • MaxMustermann2
  • TimmyExogenous

Poem

In the garden where tokens bloom,
A change has come to lift the gloom.
The total supply, now set free,
Leaves room for growth, as we all see.
Hops of joy in every byte,
A brighter path, oh what a sight! 🐇✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ffb9cb2 and e62e523.

Files selected for processing (2)
  • Dockerfile (1 hunks)
  • networks/local/exocore/Dockerfile (1 hunks)
Files skipped from review due to trivial changes (2)
  • Dockerfile
  • networks/local/exocore/Dockerfile

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloud8little cloud8little requested a review from bwhour September 19, 2024 06:18
@cloud8little cloud8little added this to the Testnet V6 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants