-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reactivated help button and fixed xquery parameters problems #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the help button works in my test with the clarinet quintet, the internal links within the help page don't work. Clicking on e.g. the link "Vorbereitung" from the help TOC opens a new browser tab with the Edirom Online index page.
This is the problem in #24 right? Can we move the conversation there and merge this one anyway because #209 was only about reactiviating, not the content and we have the #24 ? |
Ups, I didn't notice #24. But the other code comments are still valid for this PR, for those changes should be motivated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally dislike all these merge-dev-into-feature-branch commits and prefer rebasing for a clean history. That said, the code changes look ok, many thanks!
Description, Context and related Issue
The help button and page was commented out, and needed some change to be displayed and trigger help window opening.
Refs #209
How Has This Been Tested?
checked manually in Klarinettenquintett and EditionExample
Types of changes
Overview