Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] clean up uri / docUri parameters #480

Open
daniel-jettka opened this issue Nov 27, 2024 · 0 comments
Open

[BUG] clean up uri / docUri parameters #480

daniel-jettka opened this issue Nov 27, 2024 · 0 comments
Milestone

Comments

@daniel-jettka
Copy link
Contributor

Describe the problem
While reactivating the help window it became apparent that there is an inconsistency in the use of the uri / docUri parameters in the pipeline extJS view -> xql -> xslt
This was not solved in #470 and should be cleaned

To Reproduce
Relevant places:
HelpWindow.js - https://github.com/Edirom/Edirom-Online/blob/develop/app/controller/window/HelpWindow.js#L45
getHelp.xql - https://github.com/Edirom/Edirom-Online/blob/develop/add/data/xql/getHelp.xql#L41
teiBody2HTML.xsl - https://github.com/Edirom/Edirom-Online/blob/develop/add/data/xslt/tei/profiles/edirom-body/teiBody2HTML.xsl#L13

Expected behavior
Either pass a useful URI from HelpWindow.js or strip the parameter completely from teiBody2HTML.xsl

Data
Please provide a link to your data (e.g. https://github.com/Edirom/EditionExample) to see the problem or an extract of your data to reproduce the problem.

Edirom information

  • Release v1.0.0-beta.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants