removed unused xql files #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
bwbohl
previously approved these changes
Sep 7, 2024
daniel-jettka
dismissed
bwbohl’s stale review
The merge-base changed after approval.
bwbohl
approved these changes
Sep 7, 2024
bwbohl
previously approved these changes
Sep 7, 2024
|
The branch had some merge conflicts that had to be resolved locally, so I rebased it on develop and pushed it. Unfortunately this means we need someone else to review: @Edirom/edirom-online-developer please feel free ;-) |
daniel-jettka
dismissed
bwbohl’s stale review
The merge-base changed after approval.
|
Sorry, but the current PR looks rather polluted now with 93 commits and 50 changed files. My recommendation would be to clean this mess up and force push the branch. |
|
sorry for that, obviously something went wrong here… |
bwbohl
force-pushed
the
ftr/366-remove-unused-xql
branch
from
d46e2ea to
c71f856
Compare
bwbohl
approved these changes
Sep 9, 2024
|
ok fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed:
combines issues #366 #322 and #324