Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TextGrid functionality #322

Closed
DennisFriedl opened this issue May 31, 2023 · 3 comments · Fixed by #467
Closed

Remove TextGrid functionality #322

DennisFriedl opened this issue May 31, 2023 · 3 comments · Fixed by #467
Assignees
Milestone

Comments

@DennisFriedl
Copy link
Member

For example loginToTextGrid.xql and checkTextGridLogin.xql

@krHERO krHERO moved this to Backlog in Edirom Development Jul 3, 2024
@bwbohl bwbohl added this to the 1.0.0 milestone Sep 6, 2024
@peterstadler peterstadler linked a pull request Sep 6, 2024 that will close this issue
@peterstadler
Copy link
Member

there are also references to textgrid here

declare function eutil:getDoc($uri) {
if(starts-with($uri, 'textgrid:')) then(
let $session := request:get-cookie-value('edirom_online_textgrid_sessionId')
return
doc('http://textgridlab.org/1.0/tgcrud/rest/' || $uri || '/data?sessionId=' || $session)
) else (
doc($uri)
)
};
and here
if(config['sort'] == 'sortGrid')
positions = this.application.getController('desktop.Desktop').getGridPositioning(uriWindows.getCount() + i);

I think this should also be removed?

@peterstadler peterstadler removed a link to a pull request Sep 6, 2024
@bwbohl
Copy link
Member

bwbohl commented Sep 9, 2024

although d44dfd0 removed the xql files the code references above probably should be revisited

@bwbohl
Copy link
Member

bwbohl commented Nov 7, 2024

@DennisFriedl can you take care of this?

@peterstadler peterstadler linked a pull request Nov 8, 2024 that will close this issue
@bwbohl bwbohl moved this from Backlog to Ready for Review in Edirom Development Nov 8, 2024
@bwbohl bwbohl moved this from Ready for Review to In Progress in Edirom Development Nov 8, 2024
@bwbohl bwbohl moved this from In Progress to Ready for Review in Edirom Development Nov 8, 2024
DennisFriedl added a commit that referenced this issue Nov 20, 2024
## Description, Context and related Issue
- Removed the function "eutil:getDoc" which is not necessary anymore
without Textgrid
- Removed Textgrid case from "eutil:getDoc" 
- Removed Textgrid case in an OR statement

<!--- This project only accepts pull requests related to open issues.
Please link to the issue here: -->
#322

## How Has This Been Tested?
Tested with the EditionExample.

## Types of changes
- Cleaning up

## Overview
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Edirom Development Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants