Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAnnotationsOnPage.xql could return "wrong" data. #83

Closed
Tracked by #437
nikobeer opened this issue Mar 29, 2016 · 5 comments
Closed
Tracked by #437

getAnnotationsOnPage.xql could return "wrong" data. #83

nikobeer opened this issue Mar 29, 2016 · 5 comments

Comments

@nikobeer
Copy link
Member

It should be possible to exactly specify where annotations are gathered from. As I understand annotations are searched everywhere in '/db/contents/'? So if you have multiple MEI files with annotations you will possibly get "wrong" annotations (see l. 78).

Example from OPERA: working with two MEI files for prerelease final correction -> only "the first" (archived) MEI file is taken into account?

Further problem: This seems to be completely independent from getting annotations for the Annotations List and View? Here the correct file is found (specified). As a consequence you could get different annotations in annotation view compared to source view.

Would it be possible to centralize annotation management within Edirom?

@bwbohl
Copy link
Member

bwbohl commented Mar 23, 2021

this is true, while the annotation list is populated from the work.mei the getAnnotationsOnPage searches for all mei:annot in prefs:edition_path

@bwbohl
Copy link
Member

bwbohl commented Mar 23, 2021

I would suggest to define corresponding getAnnotations functions in the annotation module.

@bwbohl
Copy link
Member

bwbohl commented Nov 7, 2024

this seems connected to #156 and #240

@bwbohl
Copy link
Member

bwbohl commented Nov 7, 2024

@hizclick yet another one for the collection?

hizclick added a commit that referenced this issue Dec 2, 2024
@hizclick hizclick linked a pull request Dec 2, 2024 that will close this issue
@bwbohl bwbohl moved this from Backlog to In Progress in Edirom Development Dec 4, 2024
@hizclick
Copy link
Contributor

hizclick commented Dec 6, 2024

@nikobeer, is this issue already resolved or how can we reproduce the issue?

@hizclick hizclick removed a link to a pull request Dec 6, 2024
hizclick added a commit that referenced this issue Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Edirom Development Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants