Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAnnotationsInText.xql should search edition collection #240

Closed
Tracked by #437
bwbohl opened this issue Jun 6, 2022 · 3 comments · Fixed by #487
Closed
Tracked by #437

getAnnotationsInText.xql should search edition collection #240

bwbohl opened this issue Jun 6, 2022 · 3 comments · Fixed by #487

Comments

@bwbohl
Copy link
Member

bwbohl commented Jun 6, 2022

Currently the xql queries

collection('/db/contents')//mei:annot[matches(@plist, $uri)]

This will not properly return any annotation as the concept for installing edirom editions no longer requires them in /db/contents

@bwbohl bwbohl added this to the refactoring milestone Jun 6, 2022
@krHERO krHERO moved this to New in Edirom Development Jul 3, 2024
@krHERO krHERO removed this from the refactoring milestone Jul 4, 2024
@bwbohl bwbohl added the Type: bugfix A pull request providing a bugfix label Sep 6, 2024
@bwbohl bwbohl moved this from New to Backlog in Edirom Development Sep 6, 2024
@bwbohl bwbohl added Type: bug report and removed Type: bugfix A pull request providing a bugfix labels Sep 6, 2024
@bwbohl bwbohl added this to the 1.0.0 milestone Sep 6, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Sep 10, 2024

Connected to #83 if we go the way to define a standard function for retrieving annotations in the annotation XQuery module.

@bwbohl
Copy link
Member Author

bwbohl commented Oct 9, 2024

This would need a dataset with annotation in texts. Does anyone from @Edirom/edirom-online-developer have one at hand? Otherwise, we should push this to 1.0.1 or 1.1.0.

@bwbohl
Copy link
Member Author

bwbohl commented Nov 7, 2024

@hizkile basically here’s the same as in #156 so maybe you could tackle them in combination ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants