-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchWindow: Use edition path for collection function #156
Comments
Is there a canonical function for retrieving the edition context? Is this somehow related to #83 ? |
@roewenstrunk Kun je daar wat dieper op ingaan? |
@hizclick this is basically about the hard coded paths in Edirom-Online/add/data/xql/search.xql Lines 76 to 85 in 91abe6b
Looking at these the collection that is being queried is '/db' – the whole database. This of course might make sense in some context (e.g., when an Edirom deployment only includes one edition of one work). But, e.g., if you have multiple editions installed the search will also return hits from those. |
No there is not but there definitely should be! Such a function could be useful in many places in the Edirom Online. |
* rename module util to eutil * update module calls * renaming namespace #462 * Update testing/XQSuite/eutil-tests.xqm Co-authored-by: Dennis Ried <[email protected]> * Update add/controller.xql Co-authored-by: Dennis Ried <[email protected]> * corrected missed occurence * rename module util to eutil * update module calls * renaming namespace #462 * Update testing/XQSuite/eutil-tests.xqm Co-authored-by: Dennis Ried <[email protected]> * Update add/controller.xql Co-authored-by: Dennis Ried <[email protected]> * first shot at fixing #156 * that's actually not needed The `edition` parameter is automatically added by `window.doAJAXRequest` * move variables to query body and fix parameter name from `uri` to `edition` * fix function for displaying kwic results * improve inline function documentation * fix callback function * directly do search when query terms are entered via the top bar text input * order imports and declarations according to the Style Guide * corrected missed occurence --------- Co-authored-by: Daniel Jettka <[email protected]> Co-authored-by: Peter Stadler <[email protected]> Co-authored-by: Hizkiel <[email protected]>
* rename module util to eutil * update module calls * renaming namespace Edirom#462 * Update testing/XQSuite/eutil-tests.xqm Co-authored-by: Dennis Ried <[email protected]> * Update add/controller.xql Co-authored-by: Dennis Ried <[email protected]> * corrected missed occurence * rename module util to eutil * update module calls * renaming namespace Edirom#462 * Update testing/XQSuite/eutil-tests.xqm Co-authored-by: Dennis Ried <[email protected]> * Update add/controller.xql Co-authored-by: Dennis Ried <[email protected]> * first shot at fixing Edirom#156 * that's actually not needed The `edition` parameter is automatically added by `window.doAJAXRequest` * move variables to query body and fix parameter name from `uri` to `edition` * fix function for displaying kwic results * improve inline function documentation * fix callback function * directly do search when query terms are entered via the top bar text input * order imports and declarations according to the Style Guide * corrected missed occurence --------- Co-authored-by: Daniel Jettka <[email protected]> Co-authored-by: Peter Stadler <[email protected]> Co-authored-by: Hizkiel <[email protected]>
https://github.com/Edirom/Edirom-Online/blob/develop/add/data/xql/search.xql at the moment queries the database root (/db) collection; thus it returns result from outside the current edition context
The text was updated successfully, but these errors were encountered: