Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using pr_comment_id to simplify handling of issue comments #250

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented Feb 13, 2024

This PR is another step towards syncing bot codes used by NESSI and EESSI. It includes the following changes

  • adds a function determine_issue_comment that returns an instance of IssueComment using either the number/id of such a comment or a search pattern (for example, the name of a tarball that is included in the body of the comment for which the instance shall be returned)
  • uses this function when a comment to a pull request shall be updated
  • also adds pr_comment_id argument to function upload_tarball and in there uses the updated update_pr_comment
  • uses updated upload_tarball in function deploy_built_artefacts

Copy link
Collaborator

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@laraPPr laraPPr merged commit 9cbdec7 into EESSI:develop Feb 14, 2024
7 checks passed
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants