-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v0.4.0 #259
Merged
release v0.4.0 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge bot changes since we have software.eessi.io
- call read_job_metadata_from_file from tools/job_metadata.py - moved one test from tests for EESSIBotSoftwareLayerJobManager to tests for tools/job_metadata.py
add function that reads PR section from job metadata and use it in job manager
- adds function `determine_pr_comment_id` which reads the attribute `pr_comment_id` from the job's metadata file (all current bot instances already provide that attribute when creating the job's metadata file) - the function is then used when successful jobs are determined (in function `determine_successful_jobs`) and the comment id is added to a dictionary that contains information for each job - another function (`determine_tarballs_to_deploy`) adds the comment id to a dictionary storing information about jobs/tarballs to deploy
add function to determine comment id for a job and use it
Co-authored-by: Thomas Röblitz <[email protected]>
add PR comment id to uploaded metadata
- adds command line args to specify upload target directories/directory pattern - adds a command line arg to show variables that could be used in a directory pattern - makes the legacy path accessible (i.e., can be used in the directory pattern) - slighly modifies some variable names to make their purpose more clear - fixes small typo - makes script a bit more 'noisy' to let it tell what it does (should facilitate debugging; as some actions are more configurable it's desirable to have a bit more information about what is going on)
- read settings from config - parse settings - pass settings to upload script - adjust messages used for reporting via GitHub PR comments
fix for job manager crash: Unable to contact slurm controller
…nto configurable_upload_directory
- added new settings `metadata_prefix` and `tarball_prefix` - added new settings for reporting about pull request download failures - added missing settings for build permissions and reporting about no permissions
make upload directory in S3 bucket configurable
only respond to bot commands
spell correction Co-authored-by: Lara Ramona Peeters <[email protected]>
release notes for v0.4.0
improve release notes for v0.4.0
laraPPr
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
Bug fixes:
bot: status
command (fix forbot: status
was calling wrong values which caused thebot: status
to fail #251)Improvements:
comment_download_pr()
#248)the S3 bucket (add function that reads PR section from job metadata and use it in job manager #247, add function to determine comment id for a job and use it #249, using
pr_comment_id
to simplify handling of issue comments #250, add PR comment id to uploaded metadata #253)