Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function that reads PR section from job metadata and use it in job manager #247

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented Feb 9, 2024

This is a small change moving code that is used in eessi_bot_job_manager.py into a function defined in tools/job_metadata.py and then use that function in eessi_bot_job_manager.py.

It's a step towards syncing the codes of the NESSI and EESSI bots.

eessi_bot_job_manager.py Outdated Show resolved Hide resolved
- call read_job_metadata_from_file from tools/job_metadata.py
- moved one test from tests for EESSIBotSoftwareLayerJobManager to
  tests for tools/job_metadata.py
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge bedroge merged commit 7d822c4 into EESSI:develop Feb 12, 2024
7 checks passed
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants