Feat/ssm parameters unit test example #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhutchison
added
documentation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
- Coverage 96.42% 95.99% -0.43%
===========================================
Files 10 10
Lines 643 674 +31
Branches 134 143 +9
===========================================
+ Hits 620 647 +27
- Misses 14 16 +2
- Partials 9 11 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @shadycuz, is there any chance you'd be able to merge a few of the open PRs? Thanks. |
shadycuz
added
chore
enhancement
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the
examples/unitdirectory a readme file and two sample test cases showing covering testing parameters are valid.This includes the additional functionality to support SSM parameter types, which close #270 and complete #202. This also adds the ability to load parameters from configuration files (supporting the CodePipeline artifact and CloudFormation CLI configuration file options).
I've added in
isortas a pre-commit hook and changed flake8 to use this for checking import order too to save needing to manually reorder imports. It is pretty much the same check that was there before. When I was recreating myvenvit was failing to install so I've set the minimum taskcat version to the latest, hope that is ok.@shadycuz I suggest that this feature triggers a new release and we explore the naming/hook piece for the release after.