Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter validation #202

Closed
shadycuz opened this issue Apr 26, 2023 · 5 comments
Closed

Parameter validation #202

shadycuz opened this issue Apr 26, 2023 · 5 comments

Comments

@shadycuz
Copy link
Member

The template should provide some kinda parameter validation. Like checking if a given regex is followed or if a value is allowed via the allowed values.

@dhutchison
Copy link
Collaborator

It looks like you've merged my PR into a release for part of this area. Are you wanting to keep this open until AWS parameter types are validated too? (I'd made a start on it but got busy)

@shadycuz
Copy link
Member Author

@dhutchison I think we can keep it open since its not fully implemented, but we have a link to the PR and your comment so we have the history =)

I wasn't thinking about all these different areas of validation though, your PR covered what I had originally expected fro the feature.

@dhutchison
Copy link
Collaborator

It looks like there are actually 2 types of parameters still to handle:

  1. AWS-specific parameter types, which Inclusion of AWS type validation #239 should hopefully address (once I/someone can double check the regexes)
  2. SSM parameter types. These are an interesting one - as well as verifying that the parameter value matches the format for an SSM key, this could (and probably should) piggyback on the dynamic references work to actually resolve the parameter to a configured value

@dhutchison
Copy link
Collaborator

I think this one can now be closed now #274 is handled. Unless there are any other validations you think are missing?

@dhutchison
Copy link
Collaborator

Closing this, believe the last of this was included in v0.10.0 as the release with the final #274 in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants