Skip to content

Commit

Permalink
Update domUtils.isElementFocusable (fixes #873) (#875)
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexanderMoskovkin authored Oct 19, 2016
1 parent dc0ccbe commit 6e68759
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions src/client/utils/dom.js
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,6 @@ export function isElementFocusable (el) {
var isNotDisplayedElement = getStyle(el, 'display') === 'none';
var isHiddenElement = isWebKit ? isHidden(el) && !isOptionElement(el) : isHidden(el);

if (tabIndex !== null && tabIndex < 0)
return false;

if (isDisabledElement || isInvisibleElement || isNotDisplayedElement || isHiddenElement)
return false;

Expand Down
2 changes: 1 addition & 1 deletion test/client/data/is-focusable/iframe.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

<a>Link without href</a>
<div>div tag</div>
<input type="button" value="button input" tabindex="-1"/>
<input type="button" value="button input" tabindex="-1" class="expected"/>

<iframe class="expected"></iframe>
</body>
Expand Down

0 comments on commit 6e68759

Please sign in to comment.