Update to v9.3.12, Revert "Link in vk.com profile doesn't work (close #…

…846) (#854)" (#867) * Revert "Link in vk.com profile doesn't work (close #846) (#854)" This reverts commit 8f0578e. * Update to v9.3.12
DevExpress · Oct 17, 2016 · dc0ccbe · dc0ccbe
1 parent 776ddb0
commit dc0ccbe
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "testcafe-hammerhead",
   "description": "A powerful web-proxy used as a core for the TestCafe testing framework (https://github.com/DevExpress/testcafe).",
-  "version": "9.3.11",
+  "version": "9.3.12",
   "homepage": "https://github.com/DevExpress/testcafe-hammerhead",
   "bugs": {
     "url": "https://github.com/DevExpress/testcafe-hammerhead/issues"

diff --git a/src/client/sandbox/node/element.js b/src/client/sandbox/node/element.js
@@ -578,7 +578,7 @@ export default class ElementSandbox extends SandboxBase {
         var target = this._getEffectiveTargetValue(el);
 
         if (!ElementSandbox._isKeywordTarget(target) && !windowsStorage.findByName(target))
-            el.target = '_top';
+            el.target = '_self';
 
     }
 

diff --git a/src/client/sandbox/node/window.js b/src/client/sandbox/node/window.js
@@ -108,7 +108,7 @@ export default class WindowSandbox extends SandboxBase {
             var newArgs = [];
 
             newArgs.push(getProxyUrl(arguments[0]));
-            newArgs.push('_top');
+            newArgs.push('_self');
 
             if (arguments.length > 2)
                 newArgs.push(arguments[2]);

diff --git a/src/processing/dom/index.js b/src/processing/dom/index.js
@@ -411,7 +411,7 @@ export default class DomProcessor {
         attrValue = attrValue && attrValue.replace(/\s/g, '');
 
         if (attrValue === '_blank' || attrValue === 'blank')
-            this.adapter.setAttr(el, 'target', '_top');
+            this.adapter.setAttr(el, 'target', '_self');
     }
 
     _processUrlAttrs (el, urlReplacer, pattern) {

diff --git a/test/client/fixtures/sandbox/node/document-test.js b/test/client/fixtures/sandbox/node/document-test.js
@@ -442,7 +442,7 @@ asyncTest('multiple document.write with html and body tags should not break mark
 
             strictEqual(doc.querySelector('h1').innerHTML, 'Header');
             ok(/Text( text){19}/.test(doc.querySelector('p').innerHTML));
-            strictEqual(doc.querySelector('a').target, '_top');
+            strictEqual(doc.querySelector('a').target, '_self');
             strictEqual(doc.querySelectorAll('body > table tr > td > a > img').length, 1);
 
             document.body.removeChild(iframe);

diff --git a/test/client/fixtures/sandbox/node/dom-processor-test.js b/test/client/fixtures/sandbox/node/dom-processor-test.js
@@ -534,7 +534,7 @@ module('should ensure that target contains the existing window name (GH-247) (GH
         link.href   = 'http://example.com';
         link.target = 'wrong_window_name';
         link.addEventListener('click', function (e) {
-            strictEqual(link.target, '_top');
+            strictEqual(link.target, '_self');
 
             e.preventDefault();
             link.parentNode.removeChild(link);
@@ -567,7 +567,7 @@ module('should ensure that target contains the existing window name (GH-247) (GH
         base.target = 'wrong_window_name';
         link.href   = 'http://example.com';
         link.addEventListener('click', function (e) {
-            strictEqual(link.target, '_top');
+            strictEqual(link.target, '_self');
 
             e.preventDefault();
             link.parentNode.removeChild(link);
@@ -586,7 +586,7 @@ module('should ensure that target contains the existing window name (GH-247) (GH
         base.target = '_Parent';
         link.href   = 'http://example.com';
         link.addEventListener('click', function (e) {
-            strictEqual(link.target, '_top');
+            strictEqual(link.target, '_self');
 
             e.preventDefault();
             link.parentNode.removeChild(link);
@@ -631,7 +631,7 @@ module('should ensure that target contains the existing window name (GH-247) (GH
         area.target = 'wrong_window_name';
         area.href   = 'http://example.com';
         area.addEventListener('click', function (e) {
-            strictEqual(area.target, '_top');
+            strictEqual(area.target, '_self');
 
             e.preventDefault();
             map.parentNode.removeChild(map);
@@ -655,7 +655,7 @@ module('should ensure that target contains the existing window name (GH-247) (GH
         form.appendChild(input);
 
         form.addEventListener('submit', function (e) {
-            strictEqual(form.target, '_top');
+            strictEqual(form.target, '_self');
 
             e.preventDefault();
             form.parentNode.removeChild(form);
@@ -684,7 +684,7 @@ module('should ensure that target contains the existing window name (GH-247) (GH
         var storedNativeFormSubmit = nativeMethods.formSubmit;
 
         nativeMethods.formSubmit = function () {
-            strictEqual(form.target, '_top');
+            strictEqual(form.target, '_self');
 
             nativeMethods.formSubmit = storedNativeFormSubmit;
             start();