Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement getter for voting, delegating and revoking data and populate graph library #54

Open
4 of 5 tasks
virgile-dev opened this issue Apr 22, 2018 · 12 comments
Open
4 of 5 tasks
Assignees

Comments

@virgile-dev
Copy link
Member

virgile-dev commented Apr 22, 2018

For ballot X:

  • (1) getters for all voters to populate possible "representatives" list
  • (2) getters to get delegation data
  • (3) getters to get voting data
  • (4) getters to get revoking data
  • (5) implement third graph area proposed by @AlexJupiter

Params for delegate() function are : delegate(address from, address representative)
Params for vote() function are : vote(address voter, uint ballotId, uint voteOption)

@virgile-dev virgile-dev changed the title implement and populate graph library with voting data implement and populate graph library with voting and delegation data Apr 22, 2018
@virgile-dev
Copy link
Member Author

Voting graph bellow ballot:
capture d ecran 2018-04-22 a 13 46 54

@virgile-dev virgile-dev changed the title implement and populate graph library with voting and delegation data implement getter for voting and delegation data and populate graph library Apr 22, 2018
@virgile-dev virgile-dev changed the title implement getter for voting and delegation data and populate graph library implement getter for voting, delegating and revoking data and populate graph library Apr 22, 2018
@virgile-dev virgile-dev modified the milestones: Contracts v0.1.1, Dapp v0.2 Apr 22, 2018
@virgile-dev
Copy link
Member Author

Guys one doubt I'm having about this yes / no delegate graph is how we make it work when people have delegated their votes but the delegates haven't voted yet. How do you show that in the current setting ? @AlexJupiter @aecc

@aecc
Copy link
Collaborator

aecc commented Apr 23, 2018

In that case it wouldn't have a link between the YES and the repreentative. I think it would look ok and would be easy to understand. We can plot an example once that's implemented to see how the library will handle it

@AlexJupiter
Copy link
Member

@virgile-dev Oh good spot. I actually think a third section called “swing voters” or something could be interesting. Imagine this pool of delegates, all who have amasassed a tonne of votes, but haven’t yet decided which way they will vote. It would be a super cool indication of how the “swing voters” could tip the ballot right at the end.

If that’s not clear I’ll try to upload a sketch tomorrow!

@AlexJupiter
Copy link
Member

AlexJupiter commented Apr 24, 2018

So this is the sketch to explain my comment above:
image

I added a Playground section in the inVision Freehand document that we have been working on, so people can iterate on this if they so wish.

To explain in more detail:

  • I have added a "Unused delegate section". This will show all delegations to delegates, who have not yet decided if they are going to vote yes or no
  • Obama has 5 unused delegations and Aragon has 1 unused delegation.
  • When Obama and Aragon vote they would vote with 6 and 2 votes respectively as they will also add their own individual vote (this could be represented more clearly in the sketch I will admit).

This is considering, that when a user delegates, they do not determine how the delegate can be used. I think this is the key difference in this proposal in contrast to what @aecc proposes above.

@aecc
Copy link
Collaborator

aecc commented Apr 24, 2018

aha now I understand what @virgile-dev meant, my bad. It looks super to me :), the only comment I have is that I would place the YES/NO before the "unused". YES/NO seems more informative to be displayed first.

@aecc
Copy link
Collaborator

aecc commented May 2, 2018

working in "getters for all voters to populate possible "representatives" list"

@aecc
Copy link
Collaborator

aecc commented May 2, 2018

Working on “ getters to get delegation data"

@aecc
Copy link
Collaborator

aecc commented May 3, 2018

Working on (3)

@aecc
Copy link
Collaborator

aecc commented May 13, 2018

Working on (4)

@AlexJupiter
Copy link
Member

@aecc are you working on (5)?

@aecc
Copy link
Collaborator

aecc commented May 29, 2018

Hey @AlexJupiter , not at the moment. Probably up next. I'll remove it from In progress meanwhile

@aecc aecc removed the in progress label May 29, 2018
@medied medied assigned medied and unassigned LucasIsasmendi, aecc and Xalava Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants