Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

54 Added vote removal, getters for voted and delegated implemented an… #78

Merged
merged 2 commits into from
May 23, 2018

Conversation

aecc
Copy link
Collaborator

@aecc aecc commented May 13, 2018

…d visible in the GUI

Fixes for (3) and (4) including connection to GUI in #54

@medied @AlexJupiter @LucasIsasmendi
I propose here that we define better the terminology of "revoking" to avoid further language issues. In this code I included:

  • Remove vote: to remove a vote from YES/NO
  • Revoke: to revoke a delegation to another Voter

Let me know if you agree

Screenshots:

Remove vote:
image

Revoke:
image

@LucasIsasmendi
Copy link
Member

We should try to be as close as possible with sovereign meteor app. The UX presents the following options: cast votes, revoked votes, granted votes, remove delegation, remove votes

@medied
Copy link
Member

medied commented May 14, 2018

to avoid further language issues

Agree it's important language it's clear to avoid confusion. Following Lucas' suggestion, maybe the button saying 'remove vote' or 'remove delegation' is more explicit. Two words might seem long but it might be worth it for clarity.

@aecc
Copy link
Collaborator Author

aecc commented May 14, 2018

Agree. So it seems that we can conclude that we can use the revoke word only in past, as in "revoked". Remove vote, remove delegation, revoked vote, revoked delegation.
Do we all agree?

@AlexJupiter
Copy link
Member

@aecc this reasoning sounds good to me!

@aecc
Copy link
Collaborator Author

aecc commented May 15, 2018

Ok, I'll change the naming and push the changes.

@aecc
Copy link
Collaborator Author

aecc commented May 23, 2018

Terminology changed as discussed. Merging..

@aecc aecc merged commit 9b05e0a into master May 23, 2018
@aecc aecc deleted the 54-voting branch May 23, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants