-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
54 delegation voting #75
Conversation
.gitignore
Outdated
/package-lock.json | ||
/bower_components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete bower_components
from here (and also in your local branch if you have this folder), the right location is in dApp-Svr-Exp/
. This folder has a .gitignore file which already excludes bower_components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I will remove. I'm not sure how that folder arrived there though
@aecc @LucasIsasmendi can someone provide me with more context on I see that they're basically the ABI but want to understand how they fit into code structure under In PRs like this one the diffs are huge ( |
Yes, we are adding that files to .gitignore, in the future all local runs should compile the contract |
Also we should improve ipfs files, they are more than 3MB each, is a lot for a min file. |
@LucasIsasmendi the old ipfs js it's not used anymore. However I recommend not to remove it if we are going for a local + remote approach on IPFS nodes. |
@medied I think @LucasIsasmendi already mentioned most of it. But something to add: |
Okay this is useful context, thank you! |
Fixes (2) in #54
Graph is visualized correctly.
Some restrictions:
In order for this PR to work correctly 73 IPFS client added and calls to @aecc's server #74 needs to be merged firstWe probably need to have some discussions about the data models. To allow multiple ballots to work correctly and efficiently
Current screenshot: