forked from adopted-ember-addons/ember-cp-validations
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: updates to ember 5.3 - drops Ember 4.4 #2
Open
Pixelik
wants to merge
18
commits into
master
Choose a base branch
from
chore/updates-to-ember-5-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- otherwise the ember-4.4-lts test scenario throws Error
- otherwise ember s throws Error
…ent.filter - because PromiseManyArray.filter no longer exists in Ember 5
- as it is no longer allowed on Ember 5
- otherwise the following tests sometimes fail: - Integration | Validations | Factory - General: debounced validations - Integration | Validations | Factory - General: debounced validator should only be called once
- otherwise relevant Ember 4.4 test scenario throws Error: - required module @ember/renderer is missing
Pixelik
force-pushed
the
chore/updates-to-ember-5-3
branch
from
October 11, 2023 12:58
96429f2
to
d2fe360
Compare
Pixelik
changed the title
chore: updates to ember 5 3
breaking: updates to ember 5.3 - drops Ember 4.4
Oct 11, 2023
Pixelik
force-pushed
the
chore/updates-to-ember-5-3
branch
3 times, most recently
from
October 11, 2023 15:13
6533ee4
to
a61c20f
Compare
- otherwise the embroider test scenarios throw Error: - "EmberObject.create no longer supports defining computed properties"
Pixelik
force-pushed
the
chore/updates-to-ember-5-3
branch
from
October 12, 2023 13:31
68a2e7f
to
33e99af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves adopted-ember-addons#733
Chore
ember s
throwsError
Refactor
PromiseManyArray.filter
no longer exists in Ember 5Integration | Validations | Factory - General: debounced validations
Integration | Validations | Factory - General: debounced validator should only be called once
Breaking
Error: required module @ember/renderer is missing
Tasks: