Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(embroider-3): checks for all possible decorators #1

Closed
wants to merge 2 commits into from

Conversation

Pixelik
Copy link
Collaborator

@Pixelik Pixelik commented Oct 5, 2023

Refs #733

Changes proposed:

  • Currently, if any of the options is a CP, we create a custom class for it
  • But the current code ignores computed decorators like AliasDecoratorImpl (constructor name) in which case the Error "EmberObject.create no longer supports computed..." is still thrown. This is happening on an ember-addon v1 on Ember 4.12 during the embroider-safe scenario (embroider v3)
  • This PR is meant to handle all possible scenarios where a property is either a "traditional" computed property or a computed "decorator" property.

@Pixelik Pixelik self-assigned this Oct 5, 2023
@Pixelik Pixelik force-pushed the fix/embroider-v3-scenario-ember-5 branch 2 times, most recently from 62b2795 to f551bcd Compare October 7, 2023 13:06
@Pixelik Pixelik force-pushed the fix/embroider-v3-scenario-ember-5 branch from f551bcd to ec63e30 Compare October 7, 2023 13:12
@Pixelik
Copy link
Collaborator Author

Pixelik commented Oct 11, 2023

replaced by #2

@Pixelik Pixelik closed this Oct 11, 2023
@Pixelik Pixelik deleted the fix/embroider-v3-scenario-ember-5 branch October 11, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant