breaking: drops support for Ember < 4.8

DazzlingFugu · Oct 7, 2023 · f551bcd · f551bcd
1 parent 68f780c
commit f551bcd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 63 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
           cache: yarn
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
@@ -40,7 +40,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
           cache: yarn
       - name: Install Dependencies
         run: yarn install --no-lockfile
@@ -57,12 +57,7 @@ jobs:
       fail-fast: false
       matrix:
         try-scenario:
-          - ember-lts-3.28
-          - ember-4.0
-          - ember-lts-4.4
-          - ember-release
-          - ember-beta
-          - ember-canary
+          - ember-4.8
           # - embroider-safe
           # - embroider-optimized
 
@@ -71,7 +66,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
           cache: yarn
       - name: Install Dependencies
         run: yarn install --frozen-lockfile

diff --git a/addon/-private/options.js b/addon/-private/options.js
@@ -34,4 +34,3 @@ export default class Options {
     return OptionsObject.create(createParams, options);
   }
 }
-
diff --git a/config/ember-try.js b/config/ember-try.js
@@ -1,66 +1,17 @@
 'use strict';
 
-const getChannelURL = require('ember-source-channel-url');
 const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
 
 module.exports = async function () {
   return {
     useYarn: true,
     scenarios: [
       {
-        name: 'ember-lts-3.28',
+        name: 'ember-4.8',
         npm: {
           devDependencies: {
-            'ember-source': '~3.28.0',
-            'ember-data': '~3.28.0',
-          },
-        },
-      },
-      {
-        name: 'ember-4.0',
-        npm: {
-          devDependencies: {
-            'ember-source': '~4.0.0',
-            'ember-data': '~4.0.0',
-          },
-        },
-      },
-      {
-        name: 'ember-lts-4.4',
-        npm: {
-          devDependencies: {
-            'ember-source': '~4.4.0',
-            'ember-data': '~4.4.0',
-          },
-        },
-      },
-      {
-        name: 'ember-release',
-        npm: {
-          devDependencies: {
-            '@ember/string': '3.0.1',
-            'ember-source': await getChannelURL('release'),
-            'ember-data': 'latest',
-          },
-        },
-      },
-      {
-        name: 'ember-beta',
-        npm: {
-          devDependencies: {
-            '@ember/string': '3.0.1',
-            'ember-source': await getChannelURL('beta'),
-            'ember-data': 'beta',
-          },
-        },
-      },
-      {
-        name: 'ember-canary',
-        npm: {
-          devDependencies: {
-            '@ember/string': '3.0.1',
-            'ember-source': await getChannelURL('canary'),
-            'ember-data': 'canary',
+            'ember-source': '~4.8.0',
+            'ember-data': '~4.8.0',
           },
         },
       },

diff --git a/package.json b/package.json
@@ -104,7 +104,7 @@
     "webpack": "^5.74.0"
   },
   "engines": {
-    "node": "14.* || 16.* || >= 18"
+    "node": "16.* || >= 18"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -34,4 +34,3 @@ export default class Options {
		return OptionsObject.create(createParams, options);
		}
		}