-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakeLists: Add and support a RISCV_NONE toolchain #2428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-bellock
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/DMTF/libspdm/blob/main/doc/build.md also needs to be updated.
Done! |
alistair23
force-pushed
the
alistair/embedded
branch
from
November 8, 2023 01:40
e1a6c5b
to
907c772
Compare
jyao1
reviewed
Nov 8, 2023
alistair23
force-pushed
the
alistair/embedded
branch
from
November 8, 2023 03:40
907c772
to
1f62834
Compare
jyao1
reviewed
Nov 9, 2023
jyao1
reviewed
Nov 9, 2023
alistair23
force-pushed
the
alistair/embedded
branch
2 times, most recently
from
November 10, 2023 00:26
eee5354
to
0829897
Compare
jyao1
reviewed
Nov 10, 2023
alistair23
force-pushed
the
alistair/embedded
branch
from
November 10, 2023 09:11
0829897
to
c96d161
Compare
steven-bellock
requested changes
Nov 13, 2023
jyao1
reviewed
Nov 13, 2023
Similar to OPENSSL_FLAGS add a MBEDTLS_FLAGS CMake variable. Signed-off-by: Alistair Francis <[email protected]>
Add a RISCV_NONE toolchain to target an embedded environment. This allows building libspdm libraries with mbedtls. Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/embedded
branch
from
November 21, 2023 02:49
c96d161
to
403bb0f
Compare
jyao1
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a RISCV_NONE toolchain to target an embedded RISC-V environment.
This allows building libspdm libraries with mbedtls in an embedded environment. We can then use newlibc to create final binaries with libspdm
Tested with: