Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加自动化测试 #9

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[flake8]
max-line-length = 100
39 changes: 39 additions & 0 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# This workflow will install Python dependencies, run tests and lint with a single version of Python
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Python application

on:
push:
branches:
- master
pull_request:
branches:
- master
- dev

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Set up Python 3.7
uses: actions/setup-python@v2
with:
python-version: 3.7
- name: Install dependencies
run: |
python -m pip install --upgrade pip
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Install dependencies for testing
run: |
if [ -f requirements-test.txt ]; then pip install -r requirements-test.txt; fi
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --show-source --statistics
- name: Test with pytest
run: |
python -m pytest
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,27 @@ pip install zhdate --upgrade
```python
from zhdate import ZhDate

date1 = ZhDate(2010, 1, 1) # 新建农历 2010年正月初一 的日期对象
date1 = ZhDate(2010, 1, 1) # 新建农历 2010年正月初一 的日期对象
print(date1) # 直接返回农历日期字符串
dt_date1 = date1.to_datetime() # 农历转换成阳历日期 datetime 类型

dt_date2 = datetime(2010, 2, 6)
date2 = ZhDate.from_datetime(dt_date2) # 从阳历日期转换成农历日期对象
date2 = ZhDate.from_datetime(dt_date2) # 从阳历日期转换成农历日期对象

date3 = ZhDate(2020, 4, 30, leap_month=True) # 新建农历 2020年闰4月30日
date3 = ZhDate(2020, 4, 30, leap_month=True) # 新建农历 2020年闰4月30日
print(date3.to_datetime())

# 支持比较
if ZhDate(2019, 1, 1) == ZhDate.from_datetime(datetime(2019, 2, 5)):
pass

# 减法支持
new_zhdate = ZhDate(2019, 1, 1) - 30 #减整数,得到差额天数的新农历对象
new_zhdate2 = ZhDate(2019, 1, 1) - ZhDate(2018, 1, 1) #两个zhdate对象相减得到两个农历日期的差额
new_zhdate3 = ZhDate(2019, 1, 1) - datetime(2019, 1, 1) # 减去阳历日期,得到农历日期和阳历日期之间的天数差额
new_zhdate = ZhDate(2019, 1, 1) - 30 # 减整数,得到差额天数的新农历对象
delta1 = ZhDate(2019, 1, 1) - ZhDate(2018, 1, 1) # 两个zhdate对象相减得到两个农历日期的差额
delta2 = ZhDate(2019, 1, 1) - datetime(2019, 1, 1) # 减去阳历日期,得到农历日期和阳历日期之间的天数差额

# 加法支持
new_zhdate4 = ZhDate(2019, 1, 1) + 30 # 加整数返回相隔天数以后的新农历对象
new_zhdate4 = ZhDate(2019, 1, 1) + 30 # 加整数返回相隔天数以后的新农历对象

# 中文输出
new_zhdate5 = ZhDate(2019, 1, 1)
Expand Down
3 changes: 3 additions & 0 deletions requirements-test.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
flake8==3.9.0
importlib-metadata==4.13.0
pytest==6.0.1
20 changes: 11 additions & 9 deletions sample_zhdate.py
Original file line number Diff line number Diff line change
@@ -1,28 +1,30 @@
# -*- coding=utf-8 -*-

from zhdate import ZhDate
from datetime import datetime

if __name__ == '__main__':
date1 = ZhDate(2010, 1, 1) # 新建农历 2010年正月初一 的日期对象
date1 = ZhDate(2010, 1, 1) # 新建农历 2010年正月初一 的日期对象
# print(date1) # 直接返回农历日期字符串
dt_date1 = date1.to_datetime() # 农历转换成阳历日期 datetime 类型
dt_date1 = date1.to_datetime() # 农历转换成阳历日期 datetime 类型

dt_date2 = datetime(2010, 2, 6)
date2 = ZhDate.from_datetime(dt_date2) # 从阳历日期转换成农历日期对象
dt_date2 = datetime(2010, 2, 6)
date2 = ZhDate.from_datetime(dt_date2) # 从阳历日期转换成农历日期对象

date3 = ZhDate(2020, 4, 29, leap_month=True) # 新建农历 2020年闰4月30日
date3 = ZhDate(2020, 4, 29, leap_month=True) # 新建农历 2020年闰4月30日
# print(date3.to_datetime())

# 支持比较
if ZhDate(2019, 1, 1) == ZhDate.from_datetime(datetime(2019, 2, 5)):
pass

# 减法支持
new_zhdate = ZhDate(2019, 1, 1) - 30 #减整数,得到差额天数的新农历对象
new_zhdate2 = ZhDate(2019, 1, 1) - ZhDate(2018, 1, 1) #两个zhdate对象相减得到两个农历日期的差额
new_zhdate3 = ZhDate(2019, 1, 1) - datetime(2019, 1, 1) # 减去阳历日期,得到农历日期和阳历日期之间的天数差额
new_zhdate = ZhDate(2019, 1, 1) - 30 # 减整数,得到差额天数的新农历对象
delta1 = ZhDate(2019, 1, 1) - ZhDate(2018, 1, 1) # 两个zhdate对象相减得到两个农历日期的差额
delta2 = ZhDate(2019, 1, 1) - datetime(2019, 1, 1) # 减去阳历日期,得到农历日期和阳历日期之间的天数差额

# 加法支持
new_zhdate4 = ZhDate(2019, 1, 1) + 30 # 加整数返回相隔天数以后的新农历对象
new_zhdate4 = ZhDate(2019, 1, 1) + 30 # 加整数返回相隔天数以后的新农历对象

print(ZhDate(1900, 9, 1, False).chinese())
print(ZhDate.today().chinese())
16 changes: 8 additions & 8 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
import setuptools
# -*- coding=utf-8 -*-

'''
"""
Author : PandaWithBeard
Date : 2023-01-21 02:30:41
LastEditors : PandaWithBeard
LastEditTime : 2023-01-21 02:30:41
FilePath : /zhdate/setup.py
Description :
'''
Description :
"""

import setuptools

with open('README.md', 'r') as file:
long_description = file.read()

setuptools.setup(
name='zhdate',
version='1.0',
version='1.1',
author="PandaWithBeard",
author_email="[email protected]",
description="A pachage to convert Chinese Lunar Calendar to datetime",
long_description=long_description,
long_description_content_type="text/markdown",
url='https://github.com/CutePandaSh/zhdate',
packages=setuptools.find_packages(),
packages=setuptools.find_packages(exclude=['tests']),
classifiers=[
"Programming Language :: Python :: 3",
"License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)",
"Operating System :: OS Independent",
],
)


5 changes: 4 additions & 1 deletion test_zhdate.py → tests/test_zhdate.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# -*- coding=utf-8 -*-

import unittest
from datetime import datetime
from zhdate import ZhDate
Expand Down Expand Up @@ -60,6 +62,7 @@ def test_from_datetime(self):
((1903, 5, 17), datetime(1903, 6, 12)),
((1903, 5, 17, True), datetime(1903, 7, 11)),
((1900, 1, 20), datetime(1900, 2, 19)),
((1900, 12, 30), datetime(1901, 2, 18)),
((2050, 1, 28), datetime(2050, 2, 19)),
((2050, 3, 30, True), datetime(2050, 5, 20)),
((1900, 1, 1), datetime(1900, 1, 31)),
Expand Down Expand Up @@ -95,4 +98,4 @@ def test_validate(self):
]

for case in test_cases:
self.assertEqual(ZhDate.validate(*case[0]), case[1])
self.assertEqual(ZhDate.validate(*case[0]), case[1])
30 changes: 19 additions & 11 deletions zhdate/__init__.py
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
'''
-*- coding: utf-8 -*-
# -*- coding: utf-8 -*-

"""
File: zhdate.py
File Created: Sunday, 17th February 2019 4:58:02 pm
Author: Wang, Yi ([email protected])
'''
'''
-----
changed: Saturday, 21st January 2023
by: Eilles Wan ([email protected])
'''
'''
-----
changed: Tuesday, 14th March 2023
by: JellyBeanXiewh (https://github.com/JellyBeanXiewh)
'''
"""

from datetime import datetime, timedelta
from itertools import accumulate

Expand Down Expand Up @@ -60,17 +60,21 @@ def from_datetime(cls, dt):
ZhDate -- 生成的农历日期对象
"""
lunar_year = dt.year
# 如果还没有到农历正月初一 农历年份减去1
lunar_year -= (datetime.strptime(CHINESENEWYEAR[lunar_year - 1900], '%Y%m%d') - dt).total_seconds() > 0
# 当时农历新年时的日期对象
newyear_dt = datetime.strptime(CHINESENEWYEAR[lunar_year - 1900], '%Y%m%d')
newyear_dt = datetime.strptime(CHINESENEWYEAR[lunar_year-1900], '%Y%m%d')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不能这样写,你这个写法会导致newyear_dt是在lunar_year确定之前就已经确定了。
必须要先判断是否是农历正月初一之前,确定 lunar_year是否需要减1,之后,再获取newyear_dt的值

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修复并补充了测试

# 如果还没有到农历正月初一 农历年份减去1
lunar_year -= (newyear_dt - dt).total_seconds() > 0
# 更正当时农历新年时的日期对象
newyear_dt = datetime.strptime(CHINESENEWYEAR[lunar_year-1900], '%Y%m%d')
# 查询日期距离当年的春节差了多久
days_passed = (dt - newyear_dt).days
# 被查询日期的年份码
year_code = CHINESEYEARCODE[lunar_year - 1900]
# 取得本年的月份列表
month_days = cls.decode(year_code)

month = 0
lunar_day = 0
for pos, days in enumerate(accumulate(month_days)):
if days_passed + 1 <= days:
month = pos + 1
Expand Down Expand Up @@ -162,7 +166,11 @@ def __str__(self):
Returns:
str -- 标准格式农历日期字符串
"""
return "农历{}年{}{}月{}日".format(self.lunar_year, "闰" if self.leap_month else "", self.lunar_month, self.lunar_day)
return "农历{}年{}{}月{}日".format(
self.lunar_year, "闰" if self.leap_month else "",
self.lunar_month,
self.lunar_day
)

def __repr__(self):
return self.__str__()
Expand Down
10 changes: 5 additions & 5 deletions zhdate/constants.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
'''
-*- coding: utf-8 -*-
# -*- coding: utf-8 -*-

"""
File: constant.py
File Created: Saturday, 21st January 2023 01:42 am
Author: Eilles Wan ([email protected])
'''
"""

CHINESEYEARCODE = [
19416,
Expand Down Expand Up @@ -41,7 +42,7 @@
最后四位:表示闰月的月份,0表示当年无闰月

前四位和最后四位应该结合使用,如果最后四位为0,则不考虑前四位
例:
例:
1901年代码为 19168,转成二进制为 0b100101011100000, 最后四位为0,当年无闰月,月份数据为 010010101110 分别代表12月的大小情况
1903年代码为 21717,转成二进制为 0b101010011010101,最后四位为5,当年为闰五月,首四位为0,闰月为29天,月份数据为 010101001101 分别代表12月的大小情况

Expand Down Expand Up @@ -93,4 +94,3 @@
'''
从1900年,至2100年每年的农历春节的公历日期
'''