增加自动化测试 #9
Open
增加自动化测试 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuanshuai
commented
Sep 20, 2023
•
lihuanshuai
commented
- 增加 flake8 和 pytest 的 github action workflow，新 pr 或 push 时自动测试
- 修复相关报错
- 修改 sample 中不恰当的命名
CutePandaSh
reviewed
Sep 26, 2023
| @@ -55,17 +56,19 @@ def from_datetime(dt): | |||
| ZhDate -- 生成的农历日期对象 | |||
| """ | |||
| lunar_year = dt.year | |||
| # 如果还没有到农历正月初一 农历年份减去1 | |||
| lunar_year -= (datetime.strptime(CHINESENEWYEAR[lunar_year-1900], '%Y%m%d') - dt).total_seconds() > 0 | |||
| # 当时农历新年时的日期对象 | |||
| newyear_dt = datetime.strptime(CHINESENEWYEAR[lunar_year-1900], '%Y%m%d') | |||
There was a problem hiding this comment.
这里不能这样写，你这个写法会导致newyear_dt是在lunar_year确定之前就已经确定了。
必须要先判断是否是农历正月初一之前，确定 lunar_year是否需要减1，之后，再获取newyear_dt的值
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.