Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/azure container instances #44

Merged

Conversation

gtheodorio
Copy link
Contributor

@gtheodorio gtheodorio commented Jul 22, 2024

Resolves #42

  • get count of containers running in azure container instances

@yannhowe
Copy link

Tiny thing, need to sync up the output path and command from the benchmark script and the cloud specific python

The output looks correct.

Also its weird to have this but can fix it up some other time. Threw me off while testing.
https://github.com/gtheodorio/cloud-resource-estimator/blob/31deb3adf66840ae7a3cdb5f7188d6c09f59f9f9/benchmark.sh#L6

@carlosmmatos carlosmmatos self-requested a review July 29, 2024 14:06
@carlosmmatos carlosmmatos added enhancement New feature or request Azure Azure related issues and questions labels Jul 29, 2024
@carlosmmatos
Copy link
Contributor

@yannhowe

Also its weird to have this but can fix it up some other time. Threw me off while testing. https://github.com/gtheodorio/cloud-resource-estimator/blob/31deb3adf66840ae7a3cdb5f7188d6c09f59f9f9/benchmark.sh#L6

The reason for this is because the wrapper script (benchmark.sh) is documented as being ran standalone (ie, not git clone). Because of this, we are using curl to download the cloud python script files to execute and this currently points to the main branch. I'm creating an issue soon on cleaning up/updating the wrapper script. I think it doesn't make sense to have it download everything into the virtual env directory, and this way we don't have to change the output to any of the python scripts as the end result should always be - the csv files are saved in the local directory (whether you run them manually or via the benchmark script).

Copy link
Contributor

@carlosmmatos carlosmmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gtheodorio gtheodorio merged commit 6c2c55d into CrowdStrike:main Jul 29, 2024
4 checks passed
@gtheodorio gtheodorio deleted the feature/azure_container_instances branch July 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Azure related issues and questions enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Azure): Discover serverless workloads
3 participants