feat(gcp): updated + enhanced gcp estimation script #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmmatos
added
enhancement
This commit adds the logic/support for cloud run jobs. It also ensures that the failed service call returns a uniq set before writing to file to prevent duplicates.
|
For GKE autopilot, are you able to add the node count since daemonset is recommended for deployment? |
Clean up messaging, clean up logging, add node count, and clean up output such as table headers.
redhatrises
approved these changes
Jul 25, 2024
|
Looks like the output here needs to be synced up with the output from here since most will run from root folder the paths won't be correct. Was the same with Azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
This PR introduces several improvements, enhancements, and bug fixes that were much needed. The main issue to target was to add the inclusion of tracking serverless resources in GCP. This PR adds
On top of that, I've added better logging support and error handling, especially around service APIs that are disabled in a project that is needed. This should also Fix #40 .
Other updates: